grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] define GRUB_MOD_ALIGN to 0 on non-ieee1275 (Re: does module


From: Pavel Roskin
Subject: Re: [PATCH] define GRUB_MOD_ALIGN to 0 on non-ieee1275 (Re: does module area require alignment? (Re: [PATCH] i386-qemu port))
Date: Mon, 22 Jun 2009 15:43:17 -0400

On Mon, 2009-06-22 at 14:31 +0200, Robert Millan wrote:
> Well it seems that OLPC (i386-ieee1275) needs alignment, but coreboot doesn't.
> It must be some OFW-specific oddity.
> 
> This patch makes the alignment ieee1275-specific on i386.

We can define GRUB_MOD_ALIGN to 1 for such architectures and keep using
ALIGN_UP (or remove ALIGN_UP - it doesn't matter).  The value of 0 for
GRUB_MOD_ALIGN is meaningless, but the value of 1 has a meaning - align
to a byte boundary.

-- 
Regards,
Pavel Roskin




reply via email to

[Prev in Thread] Current Thread [Next in Thread]