[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH]: grub: Fix handling of long printf arguments on 64-bit.
From: |
Isaac Dupree |
Subject: |
Re: [PATCH]: grub: Fix handling of long printf arguments on 64-bit. |
Date: |
Sun, 12 Apr 2009 10:19:18 -0400 |
User-agent: |
KMail/1.10.4 (Linux/2.6.27-11-generic; KDE/4.1.4; x86_64; ; ) |
> - grub_ltoa (tmp, c, l);
> + grub_lltoa (tmp, c, l);
> }
> else
> {
> n = va_arg (args, int);
> - grub_itoa (tmp, c, n);
> + grub_lltoa (tmp, c, n);
Do you think they deserve a comment saying why lltoa and that e.g. grub_ltoa
would work equally well there except for space reasons? (In case we ever
decided to change that code back, it would be easier to figure out.)
-Isaac
- [PATCH]: grub: Fix handling of long printf arguments on 64-bit., David Miller, 2009/04/11
- Re: [PATCH]: grub: Fix handling of long printf arguments on 64-bit., Yoshinori K. Okuji, 2009/04/11
- Re: [PATCH]: grub: Fix handling of long printf arguments on 64-bit., David Miller, 2009/04/11
- Re: [PATCH]: grub: Fix handling of long printf arguments on 64-bit., phcoder, 2009/04/11
- Re: [PATCH]: grub: Fix handling of long printf arguments on 64-bit., Pavel Roskin, 2009/04/11
- Re: [PATCH]: grub: Fix handling of long printf arguments on 64-bit., David Miller, 2009/04/12
- Re: [PATCH]: grub: Fix handling of long printf arguments on 64-bit., phcoder, 2009/04/12
- Re: [PATCH]: grub: Fix handling of long printf arguments on 64-bit.,
Isaac Dupree <=
- Re: [PATCH]: grub: Fix handling of long printf arguments on 64-bit., Pavel Roskin, 2009/04/12
- Re: [PATCH]: grub: Fix handling of long printf arguments on 64-bit., Pavel Roskin, 2009/04/12
- Re: [PATCH]: grub: Fix handling of long printf arguments on 64-bit., Pavel Roskin, 2009/04/12
- Re: [PATCH]: grub: Fix handling of long printf arguments on 64-bit., phcoder, 2009/04/12
- Re: [PATCH]: grub: Fix handling of long printf arguments on 64-bit., Pavel Roskin, 2009/04/13
- Re: [PATCH]: grub: Fix handling of long printf arguments on 64-bit., phcoder, 2009/04/15
Re: [PATCH]: grub: Fix handling of long printf arguments on 64-bit., Pavel Roskin, 2009/04/12