grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH]: grub: Fix handling of long printf arguments on 64-bit.


From: Pavel Roskin
Subject: Re: [PATCH]: grub: Fix handling of long printf arguments on 64-bit.
Date: Sun, 12 Apr 2009 02:39:22 -0400

On Sat, 2009-04-11 at 01:08 -0700, David Miller wrote:
> The grub printf code tries to treat 'long' and 'int' the same,
> that doesn't work on (most) 64-bit platforms.

> +      n = (unsigned) (-((long) n));

"unsigned" means "unsigned int".  You need "unsigned long" here.

It's probably irrelevant if we kill grub_ltoa(), but anyway, let's be
careful.

-- 
Regards,
Pavel Roskin




reply via email to

[Prev in Thread] Current Thread [Next in Thread]