[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH]: grub: Fix handling of long printf arguments on 64-bit.
From: |
Pavel Roskin |
Subject: |
Re: [PATCH]: grub: Fix handling of long printf arguments on 64-bit. |
Date: |
Sun, 12 Apr 2009 02:39:22 -0400 |
On Sat, 2009-04-11 at 01:08 -0700, David Miller wrote:
> The grub printf code tries to treat 'long' and 'int' the same,
> that doesn't work on (most) 64-bit platforms.
> + n = (unsigned) (-((long) n));
"unsigned" means "unsigned int". You need "unsigned long" here.
It's probably irrelevant if we kill grub_ltoa(), but anyway, let's be
careful.
--
Regards,
Pavel Roskin
- Re: [PATCH]: grub: Fix handling of long printf arguments on 64-bit., (continued)
- Re: [PATCH]: grub: Fix handling of long printf arguments on 64-bit., Pavel Roskin, 2009/04/11
- Re: [PATCH]: grub: Fix handling of long printf arguments on 64-bit., David Miller, 2009/04/12
- Re: [PATCH]: grub: Fix handling of long printf arguments on 64-bit., phcoder, 2009/04/12
- Re: [PATCH]: grub: Fix handling of long printf arguments on 64-bit., Isaac Dupree, 2009/04/12
- Re: [PATCH]: grub: Fix handling of long printf arguments on 64-bit., Pavel Roskin, 2009/04/12
- Re: [PATCH]: grub: Fix handling of long printf arguments on 64-bit., Pavel Roskin, 2009/04/12
- Re: [PATCH]: grub: Fix handling of long printf arguments on 64-bit., Pavel Roskin, 2009/04/12
- Re: [PATCH]: grub: Fix handling of long printf arguments on 64-bit., phcoder, 2009/04/12
- Re: [PATCH]: grub: Fix handling of long printf arguments on 64-bit., Pavel Roskin, 2009/04/13
- Re: [PATCH]: grub: Fix handling of long printf arguments on 64-bit., phcoder, 2009/04/15
Re: [PATCH]: grub: Fix handling of long printf arguments on 64-bit.,
Pavel Roskin <=