grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: precision formatting in grub_printf


From: Christian Franke
Subject: Re: precision formatting in grub_printf
Date: Tue, 24 Mar 2009 21:39:06 +0100
User-agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.16) Gecko/20080702 SeaMonkey/1.1.11

Deepak Vankadaru wrote:
Hi,

There was a redundant piece of code in the diff file I sent earlier. I have removed it and prepared another patch file. I am attaching the same. Please use this one instead.

Following is the changelog.

Changelog:
2008-08-17 Deepak Vankadaru <address@hidden <mailto:address@hidden>>

       Support for precision formatting in grub_printf

* kern/misc.c: modified grub_vsprintf to parse and handle precision formatting


Thanks.

Unfortunately, the patch can no longer be applied to current svn without a conflict. The precision parsing and '%s' precision (truncation) handling is already implemented.

But the '%d' precision (zero fill) handling part of your patch is still missing in the code.

Could you please repost an updated patch in diff -u format?
Note that the current code does not use a format2_default flag buts sets format2 to ~0U ('infinite' :-) if no precision is specified.

Thanks

--
Christian Franke





reply via email to

[Prev in Thread] Current Thread [Next in Thread]