grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH] fix for a memleak in grub_ntfs_mount


From: Felix Zielcke
Subject: [PATCH] fix for a memleak in grub_ntfs_mount
Date: Wed, 20 Aug 2008 23:01:26 +0200

I have just run valgrind on grub-probe /
Attached is a patch to fix a memleak in grub_ntfs_mount, which is very
obvious if you look at the code.
Probable there's nothing wrong with it and I could just commit it, but
as always I want to be sure :)


I attached the full valgrind output too.
Though it's with grub-probe compiled with the ntfs fix so it doestn't
appear there.

The first one:

==11709==    by 0x40431F: grub_guess_root_device (getroot.c:379)
==11709==    by 0x4016CC: probe (grub-probe.c:122)

is about device_name in probe ()
Not a real problem and too fix it you'd need to introduce a temporary
variable just to make valgrind happy.

For the others I wasn't yet able to find out if they're real problems or
if it just valgrind is confused.


Attachment: ntfs_memleak.diff
Description: Text Data

Attachment: valgrind.log
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]