Re: [PATCH] change grub_print_error to use stderr for the utils

[Felix Zielcke]

Am Dienstag, den 12.08.2008, 17:30 +0200 schrieb Felix Zielcke:
> Here's now the patch Robert requested.
> grub_print_error shouldn't use stdout for the utils.
> 
> Why?
> 
> # grub-install /dev/sda
> Unknown extra argument `Unsupported'.
> 

Ok this is only clear for Bean, Robert and me :)
So here's a longer explaination for this.

The Unsupported comes from here

address@hidden:~/grub/grub2.svn$ grep -r "Unsupported" *
disk/raid.c:              "Unsupported RAID version: %d.%d",
disk/raid.c:              "Unsupported RAID level: %d",
disk/raid.c:              "Unsupported RAID5 layout: %d",

In my case it's Unsupported RAID level: 6

The problem is grub_print_error () uses stdout even for grub-probe which
is used by the grub-install script
So instead of ext2 or whatever grub-probe would display for
grub-install, grub-install get's Unsupported.

It isn't right to use stdout for errors in the utils.
real grub of course doestn't care about stdout or stderr.