[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] generic ELF version of grub-mkimage

From: Robert Millan
Subject: Re: [PATCH] generic ELF version of grub-mkimage
Date: Mon, 1 Oct 2007 16:53:54 +0200
User-agent: Mutt/1.5.13 (2006-08-11)


On Thu, Aug 30, 2007 at 12:03:47PM +0200, Patrick Georgi wrote:
> Hi,
> the attached patch makes powerpc-ieee1275's grub-mkimage work with 
> little endian ELF images, too.
> I did this, as I need basically the same functionality for 
> i386-linuxbios, just with little endian ELFs. I first copied and changed 
> the file for my needs, but it might be more generally useful (other 
> architectures), and having to maintain two very similar files seems like 
> a waste of time to me - hence the merged version.
> I also moved the file to util/elf, to denote that it's a generic ELF 
> mangler now and adapted the powerpc makefile.

I think the endianess checks are overkill.  AFAICT grub-mkimage isn't really
meant for non-native use (as exemplified by the fact that it's not called
grub-mkelfimage vs grub-mkaoutimage).

I propose the following:

2007-10-01  Robert Millan  <address@hidden>

        * conf/powerpc-ieee1275.rmk (grub_mkimage_SOURCES): Replace reference
        to util/powerpc/ieee1275/grub-mkimage.c with util/elf/grub-mkimage.c.

        * include/grub/powerpc/ieee1275/kernel.h: Rename
        * kern/powerpc/ieee1275/init.c: Replace GRUB_IEEE1275_MOD_ALIGN with
        * util/elf/grub-mkimage.c: Replace GRUB_IEEE1275_MOD_ALIGN with
        GRUB_MOD_ALIGN.  Remove all use of endian conversion macros, since
        they break LE platforms and grub-mkimage is only meant for native
        use anyway.

2007-10-01  Robert Millan  <address@hidden>

        * util/powerpc/ieee1275/grub-mkimage.c: Moved to ...
        * util/elf/grub-mkimage.c: ... here.

The attached patch has been tested on Qemu/LinuxBIOS and on my Efika

Robert Millan

<GPLv2> I know my rights; I want my phone call!
<DRM> What use is a phone call, if you are unable to speak?
(as seen on /.)

Attachment: mkimage.diff
Description: Text Data

reply via email to

[Prev in Thread] Current Thread [Next in Thread]