Re: [PATCH] efika memory issues

[Robert Millan]

On Mon, Jul 30, 2007 at 05:35:28PM -0500, Hollis Blanchard wrote:
> >         When GRUB_IEEE1275_FLAG_EFIKA_SECRET_AVAILABLE_REGION was set,
> >         release hardcoded 0x4000:0xffc000 region.
> 
> Hmm, does this actually work? Since GRUB itself falls within that
> regions, the grub_ieee1275_release() call will mark all the memory
> that the GRUB kernel and modules occupy as free, which means they will
> be clobbered by heap usage.

Didn't think of this.. (by chance it worked here, though).  How about using
max(_end,0x4000) instead of 0x4000 ?

(and adjusting region length not to overflow 0x1000000)

-- 
Robert Millan

My spam trap is address@hidden  Note: this address is only intended
for spam harvesters.  Writing to it will get you added to my black list.