Re: [PATCH] terminal is not set back to console

[Robert Millan]

On Thu, May 03, 2007 at 11:46:16PM +0200, Yoshinori K. Okuji wrote:
> On Thursday 03 May 2007 21:05, Robert Millan wrote:
> > On Thu, May 03, 2007 at 08:50:11PM +0200, Robert Millan wrote:
> > > When using gfxterm, and booting a kernel in this mode, Linux won't be
> > > able to print anything to the console.  This patch fixes it so that
> > > terminal is set back to normal console during deinitialisation.
> > >
> > > Tested and known to work, although I'm not 1:1 sure if this is the right
> > > place to do it.
> >
> > Btw, should other platforms do the same?
> 
> Do you mean other terminals? Generally, yes. If you don' have any good 
> reason, 
> it is always nice to reset states to the original.

No, I really mean other platforms (i386/efi, etc).  My patch sets console as
the default terminal when unloading it.  It doesn't set state back to what
it was before loading console.  If other terminals did the same, results
would be undefined.

-- 
Robert Millan

My spam trap is address@hidden  Note: this address is only intended
for spam harvesters.  Writing to it will get you added to my black list.