grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: update-grub2 patch


From: Robert Millan
Subject: Re: update-grub2 patch
Date: Fri, 4 May 2007 09:14:46 +0200
User-agent: Mutt/1.5.13 (2006-08-11)

On Thu, May 03, 2007 at 11:44:14PM +0200, Yoshinori K. Okuji wrote:
> On Thursday 03 May 2007 17:48, Robert Millan wrote:
> > On Wed, May 02, 2007 at 03:31:16PM +0200, Robert Millan wrote:
> > > > You should avoid ! in test. Use else instead.
> > >
> > > Earlier when I read the portability document I was pointed to, I found:
> > >
> > >   "You may use `!' with `test', but not with `if'"
> > >
> > > Are you sure this change is required?
> >
> > Well, since this is just one line, I fixed it.
> >
> > Attached new patch fixes all three problems ('which', 'test !' and 'test
> > -z|-n') and also adds code in 00_header.in to enable gfxterm when the
> > unicode font is found in /boot/grub.
> >
> > Let me know if everything is ok now..
> 
> OK. Please go ahead.

Done!

-- 
Robert Millan

My spam trap is address@hidden  Note: this address is only intended
for spam harvesters.  Writing to it will get you added to my black list.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]