Re: [patch] 64 bit disk address support (= 8192EiB disks)

[Yoshinori K. Okuji]

On Saturday 22 October 2005 01:53 pm, Timothy Baldwin wrote:
> That is exactly my point. POSIX uses off_t as a byte counts into files, the
> type we are discussing the name of is used for sector counts.

OK. That makes sense.

However, I do not like grub_sector_t. For me, this is still an address or an 
offset. So it should be called something like grub_disk_addr_t or 
grub_sector_offset_t.

> > > Also grub_off_t is used in kern/mm.c to count bytes of memory.
> >
> > What is bad?
>
> It should use grub_size_t for memory, in order follow POSIX.

It's true. So we must fix it.

Okuji