Re: [groff] 1.22.4.rc4 - Final RC before official 1.22.4

[Bertrand Garrigues]

Hi Ingo,

On Sun, Dec 09 2018 at 02:32:00 PM, Ingo Schwarze <address@hidden> wrote:
> Ralph Corderoy wrote on Sun, Dec 09, 2018 at 10:36:25AM +0000:
>> The time-honoured way to achieve this is using the built-in `set'.
>> 
>>     $ l='foo bar xyzzy'
>>     $ set -- $l; for f; do echo f=$f; done | fmt
>>     f=foo f=bar f=xyzzy
>>     $
> [...]
>>     $ l=
>>     $ set -- $l; for f; do echo f=$f; done | fmt
>>     $ set -- $l; for f; do echo f=$f; done | wc -c
>>     0
>>     $ 
>
> Good point, indeed i wasn't aware of that technique.
> Arguably, using it is less intrusive than deleting the very likely
> usused variables.
>
> Then again, i already have an OK from gbranden@ to remove the
> variables, and we should probably remove them after release anyway.
>
> What do you guys want:
>
> Should i push my patch to remove the two variables,
> or rework it using Ralph's suggestion instead?

I vote for simplicity, so the removal of the 2 variables.

Thanks,

Regards,

Bertrand