[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Groff] [groff] 01/01: Makefile.sub in whole groff source tree: add
From: |
Bertrand Garrigues |
Subject: |
Re: [Groff] [groff] 01/01: Makefile.sub in whole groff source tree: add $(RM) and change all `rm -f'. Add directory test before `rmdir'. |
Date: |
Sat, 20 Sep 2014 20:23:15 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) |
Hello,
On Sat, Sep 20 2014 at 05:48:30 PM, Steffen Nurpmeso <address@hidden> wrote:
> Werner LEMBERG <address@hidden> wrote:
> |Bernd, are you aware that Steffen has done exactly the opposite in
> |commit efc407da104b7882a8139b7ba4b1e2909dfded76? Unfortunately, I no
> |longer can remember why he did the change (and there isn't an
> |explanation in the ChangeLog)...
>
> It was not used consistently all across the codebase.
>
> .. And also i personally don't see the point in adding a make
> variable for a single program, whereas all others are fixed.
> So -- if you want to change the way program xy behaves, write
> a shell script that behaves the way you want and place it first in
> PATH=.
>
> |Note that `RM' should be rather defined once in a top-level Makefile
> |and not many times in the various `Makefile.sub' files.
On the automake2 branch I've added a m4 macro to detect if RM is
supported by make. If it's not the case I force RM = rm -f in the
top-level Makefile.am. $(RM) can then be safely used in any .am file. I
haven't replaced all the rm -f by $(RM) though.
Regards,
--
Bertrand Garrigues