[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[GNUnet-developers] Broken udp plugin? ARM test fails

From: LRN
Subject: [GNUnet-developers] Broken udp plugin? ARM test fails
Date: Fri, 24 Apr 2015 03:57:22 +0300
User-agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:40.0) Gecko/20100101 Thunderbird/40.0a1

When test_gnunet_service_arm runs, it fails for me.
Debugging shows that it segfaults while loading udp plugin (LoadLibrary()
call). The crash happens deep in W32 libs, so i don't know exactly why this

The change that introduced this error happened somewhere between 23 Feb and 28
Mar of 2015, W32 buildslave (or buildmaster) didn't work at the time, so we
don't have the precise bot reports for that period.

After git-bisecting i found that
27a9e1b1a7e7c1454eae1337c8c63a4fa2d722f6 is the first bad commit
commit 27a9e1b1a7e7c1454eae1337c8c63a4fa2d722f6
Author: grothoff <address@hidden>
Date:   Sat Mar 7 20:18:54 2015 +0000

    simplify test, log failure cause


The commit does not touch udp, but does change test_gnunet_service_arm. It's
full of style fixes (hey, grothoff! Thank you for mixing style fixes and
meaningful code changes!), but does have this noticeable chunk of code removed:

-  char *armconfig;
-  if (NULL != cfgfile)
-  {
-    if (GNUNET_OK !=
-        GNUNET_CONFIGURATION_get_value_filename (c, "arm", "CONFIG",
-                                                 &armconfig))
-    {
-      GNUNET_CONFIGURATION_set_value_string ((struct
-                                             "arm", "CONFIG",
-                                             cfgfile);
-    }
-    else
-      GNUNET_free (armconfig);
-  }

No explanation is given other than "simplify test, log failure cause" (hey,
grothoff! Thank you for almost never leaving descriptive commit messages!).

Note that other ARM tests do have this chunk of code.

Adding this chunk back solves the problem for me - test_gnunet_service_arm does
not crash. Here's a patch.

O< ascii ribbon - stop html email! -

Attachment: 0001-Partially-revert-r35356.patch
Description: Text document

Attachment: 0x922360B0.asc
Description: application/pgp-keys

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]