[GNUnet-developers] libextractor ole2 and libgsf

[Glenn L McGrath]

Hi,

Firstly, congratulations on libextractor becoming an official gnu
project, the extra resources and attention should be be good
for libextractor.

There has been a niggling problem with the ole2 module of libextractor
for a while, it has been worked around within debian (1), but gentoo
still has problems with it (2), and i suspect it may cause problems to
others in the future.

The problems relates to the ole2 module linking to glib and duplicate
symbols, i dont think i understand the precise nature of the problem
(which means you should be sceptical about my patch), but think i may
have a better solution than static linking to glib.

The attached patch removes the gsf-* code in libextractor and simply
links to the shared libgsf-1 library.

Advantages i see
 - The glib linking problem is passed off to libgsf
 - Libgsf may expand in the future to support more formats.
 - less code to maintain/better code reuse

The only test i have done is libextractor's make check, which works
fine.

I dont have an ole2 file to test it with and dont know much about the
format, anyone know where i can get one ?

If this is a resonable solution i will do a better patch that cleans up
configure.ac as well.


Thanks

Glenn


1) http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=282342
2) http://bugs.gentoo.org/show_bug.cgi?id=79704

libgsf.patch
Description: Text Data