[GNUnet-developers] Re: ecrs bug

[Christian Grothoff]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Monday 01 March 2004 05:28 pm, Igor wrote:
> Just noted that if I _index_ a file with size
> less than 1kb, it will not be downloadable at all,
> not even locally. Same file works ok if _inserted_.
>
> I'll leave fixing this up to you, as you probably
> can track & fix it in a jiffy.

Ok, got it.  The problem was that the DBlock-insert routine assumed that the 
corresponding IBlock would set the hash in the super-bloomfilter.  Since for 
<1k files there is no IBlock and no super-hash, there was nothing set in 
either bloomfilter and thus the queries for <1k files were blocked at the 
bloomfilter level.

Now, there are two possible fixes.  One teaches the DBlock-insert to set the 
right bits (here in the single-bloomfilter).  Another possibility is to just 
always force insertion (and never do indexing) for files <1k. The latter is 
slightly less work to do and a better solution since none of the performance 
benefits apply for indexing files that are smaller than 1k. I've put the code 
that overrides the index option in favor of insertion for files <= 1k into 
CVS.

Christian
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.7 (GNU/Linux)

iD8DBQFARKyD9tNtMeXQLkIRApvMAJ9X/xsCgE9QNryur3XcAfPzKcF/eACdGn7V
rY0OZs/O+KB3llmhcTOAdJE=
=3R2V
-----END PGP SIGNATURE-----