[gnugo-devel] followup evaluation

[Paul Pogonyshev]

- threaten_to_capture_helper() and pattern `Sente12' retired

i propose to remove pattern `Sente12' because it does a subset
of work done by ATTACK_THREAT move valuation in `value_moves.c'.
there are some differences in the code and so removal of this
pattern causes one fail in blunder:17.  however, i think we
should rather improve/fix the code in `value_moves.c' than
keep two pieces of similar code.

Paul


Index: patterns/helpers.c
===================================================================
RCS file: /cvsroot/gnugo/gnugo/patterns/helpers.c,v
retrieving revision 1.54
diff -u -p -r1.54 helpers.c
--- patterns/helpers.c  6 Aug 2003 14:50:51 -0000       1.54
+++ patterns/helpers.c  11 Aug 2003 20:22:26 -0000
@@ -299,6 +299,9 @@ prevent_attack_threat_helper(int move, i
 }
 
 
+/* This function is obsolete.  Code in `value_moves.c' is more general. */
+#if 0
+
 /*
  * This is intended for use in autohelpers.
  *
@@ -373,6 +376,8 @@ threaten_to_capture_helper(int move, int
   add_followup_value(move, 2.0 * worm[str].effective_size);
   TRACE("...followup value %f\n", 2.0 * worm[str].effective_size);
 }      
+
+#endif
 
 
 /*
Index: patterns/patterns2.db
===================================================================
RCS file: /cvsroot/gnugo/gnugo/patterns/patterns2.db,v
retrieving revision 1.63
diff -u -p -r1.63 patterns2.db
--- patterns/patterns2.db       18 Jul 2003 18:59:22 -0000      1.63
+++ patterns/patterns2.db       11 Aug 2003 20:22:28 -0000
@@ -2922,21 +2922,22 @@ Pattern Sente11
 ;oplay_attack(*,A)
 
 
-Pattern Sente12
-# For performance reason this pattern has s classification and an
-# explicit safety test in the constraint. Thus the safety test can be
-# shortcut by the preceding liberty test.
-# tm removed attack in ko from constraint.  (3.1.20) (see trevorc:310)
-
-*X
-
-:-,sX
-
-*A
-
-;lib(A) == 2 && !attack(A) && !oplay_attack(*,*)
-# Action adds a followup value unless the threat is considered ineffective.
->threaten_to_capture(A)
+# pp Removed - this pattern is obsolete (3.5.1)
+# Pattern Sente12
+# # For performance reason this pattern has s classification and an
+# # explicit safety test in the constraint. Thus the safety test can be
+# # shortcut by the preceding liberty test.
+# # tm removed attack in ko from constraint.  (3.1.20) (see trevorc:310)
+#
+# *X
+#
+# :-,sX
+#
+# *A
+#
+# ;lib(A) == 2 && !attack(A) && !oplay_attack(*,*)
+# # Action adds a followup value unless the threat is considered ineffective.
+# >threaten_to_capture(A)
 
 
 Pattern Sente13