Re: [gnugo-devel] cosmic patch

[bump]

Stephane wrote:

> The hunk starting at line 247 and ending at line 320 of the
> patch is not applied correctly, for some reason. Specificaly,
> the end of the hunk (lines 311-318) is forgotten, which has
> the net effect of removing I patterns from the
> influence_callback() function...

It doesn't look to me as if there is a hunk starting at
line 247 in either this version of the patch:

http://mail.gnu.org/archive/html/gnugo-devel/2003-08/msg00056.html

or this one:

http://www.gnu.org/software/gnugo/patches/cosmic_5_1.2

> Lines 834-869 in influence.c should read like that
> (maybe you could restore lines 859-868 directly in CVS) :

The patch is not in the CVS. Let's get a correct patch
before we add it.

I think you are saying that these lines should be put back:

    /* Increase strength if we're computing escape influence. */
    if (q == &escape_influence && (pattern->class & CLASS_e))
      add_influence_source(pos, this_color, 20 * source_strength, 1.6, q);
    else
      add_influence_source(pos, this_color, source_strength, 1.6, q);
    
    DEBUG(DEBUG_INFLUENCE,
          "  low intensity influence source at %1m, strength %f, color %C\n",
          pos, pattern->value, this_color);
    return;

If I do that, I get error messages:

influence.c: In function `influence_callback':
influence.c:860: `source_strength' undeclared (first use in this function)
influence.c:860: (Each undeclared identifier is reported only once
influence.c:860: for each function it appears in.)

So there must be further problems with the patch.

Dan