[GNUe-dev] Changed behaviour of form.commit ()

[Johannes Vetter]

Hi,

it's me again :)

I've changed the behaviour of GFForm.commit () to do only a single
commit per backend-connection instead of doing multiple commits on the
same connection per block/datasource connected to it.

If you have a form with two blocks (datasources) both connected to the
same 'backend'-connection, a call of 'commit' would have produced two
commits on the backend before. I think this does not fit to the idea of
a 'transaction'. What if the first block's commit was ok, but the second
failed ? In such a case, all changes from the first block would be
stored persitently but the changes to the second block are lost ... ?! 

Please have a look at your forms the next days if everything is still
fine, or if you encounter (or see) problems with a commit called only
once per connection. Btw. calling block.commit () still works (by
implicitly calling block._form.commit ()) but it prints a depreciation
warning.

Additionally I've fixed a bug where forms were hanging if a commit
failed or was aborted.


Thanks,
Johannes



-- 
BYTEWISE Software GmbH          Tel +43 (5577) 89877-0
i.A. Johannes Vetter            Fax +43 (5577) 89877-66
A-6890 Lustenau, Enga 2         http://www.bytewise.at
-------------------------------------------------------
Wir bieten die Installation von Debian GNU/Linux auf
Servern für kleinere Netzwerke zum Pauschalpreis an.
Mehr dazu unter http://www.bytewise.at/texte/pl-debian

signature.asc
Description: Dies ist ein digital signierter Nachrichtenteil