Re: [Gnash-dev] Re: Testing API

[Benjamin Wolsey]

>   I'm just trying to suggest we avoid arguing over this issue and just
> keep doing what we're already doing. We've had this testing API
> discussion before, actually several times. When you talk about
> cooperation, one thing is to avoid arguing over trivial issues, and to
> focus on the areas we agree.

I also agree that the check API has several advantages over the way
you've done the tests. Sandro has already mentioned the fact that it
reports the expected and actual results. In addition, it requires only
one change to update the expected results, and reports the same line
number for passes and failures.

Also, the test was originally written using the check API and wasn't
changed until you recently started working on it. Finally, the entire
actionscript.all testsuite is consistent apart from this one test now. I
think it's a bad decision to introduce that inconsistency.

bwy

--
The current release of Gnash is 0.8.7
http://www.gnu.org/software/gnash/

Benjamin Wolsey, Software Developer - http://benjaminwolsey.de
C++ and Open-Source Flash blog - http://www.benjaminwolsey.de/bwysblog

xmpp:address@hidden
http://identi.ca/bwy

signature.asc
Description: Dies ist ein digital signierter Nachrichtenteil