Re: [Gnash-dev] Compatible libagg now in Fedora Core 6 updates

[John Gilmore]

> > Actually, as I write this mail a voice in my head tells me
> > gnash is not actually checking version but grepping in headers,
> > can you confirm Gnash would build with AGG renderer ("2.4" on fedora core?).
> 
> I checked (not on fedora core 6, but on devel when it was updated to the
> newer 2.4).

CVS Gnash does not build with the agg-2.4-2.1 that's in Fedora Core 6.
Here's the error message:

render_handler_agg.cpp:168:30: error: agg_gradient_lut.h: No such file or 
directory

(followed by a cascade of other errors).

./configure warns, saying that I should upgrade to agg-2.4, but I'm already
at agg-2.4.  Now that agg-2.5 was released (in Oct 2006), configure should
recommend upgrading to 2.5 if that header file is not present.

There is a newer agg-2.4-2.2 in Fedora Core Updates that does compile, 
though it produces a metric ton of long scary warnings, like this:

/usr/include/agg2/agg_color_gray.h: In member function 'const agg::gray16& agg::
gray16::demultiply()':
/usr/include/agg2/agg_color_gray.h:338: warning: enumeral and non-enumeral type 
in conditional expression
/usr/include/agg2/agg_scanline_bin.h: At global scope:
/usr/include/agg2/agg_scanline_bin.h:189: warning: unused parameter 'min_x'
/usr/include/agg2/agg_scanline_bin.h:189: warning: unused parameter 'max_x'
/usr/include/agg2/agg_rasterizer_sl_clip.h:320: warning: unused parameter 'x1'
 ...
render_handler_agg.cpp: In member function 'void gnash::render_handler_agg<Pixel
Format>::set_invalidated_regions(const gnash::InvalidatedRanges&) [with PixelFor
mat = agg::pixfmt_alpha_blend_rgb<agg::blender_rgb_pre<agg::rgba8, agg::order_rg
b>, agg::row_accessor<unsigned char> >]':
render_handler_agg.cpp:1908:   instantiated from here
render_handler_agg.cpp:1771: warning: comparison between signed and unsigned int
eger expressions

Most of these warnings are not fixed in agg-2.5.  Udo, have you
debugged the warnings to make sure they're AGG's fault rather than
gnash's, and reported them upstream?  I'll append all the ones I see
when building with agg-2.5 below.  (I was unable to find a maintained
agg CVS tree.)

        John

 g++ -DHAVE_CONFIG_H -I. -I. -I.. -I.. -I.. -I../server -I../server/parser 
-I../libbase -I../backend -I../libgeometry -pthread -I/usr/include/SDL 
-I/usr/include/pango-1.0 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include 
-I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/atk-1.0 
-I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include 
-I/usr/local/agg25/include/agg2 -g -O2 -pthread -march=athlon64 -W -Wall 
-Wcast-align -Wcast-qual -Wpointer-arith -Wreturn-type -MT 
render_handler_agg.lo -MD -MP -MF .deps/render_handler_agg.Tpo -c 
render_handler_agg.cpp  -fPIC -DPIC -o .libs/render_handler_agg.o
/usr/local/agg25/include/agg2/agg_color_gray.h: In member function 'const 
agg::gray16& agg::gray16::demultiply()':
/usr/local/agg25/include/agg2/agg_color_gray.h:347: warning: enumeral and 
non-enumeral type in conditional expression
/usr/local/agg25/include/agg2/agg_scanline_bin.h: At global scope:
/usr/local/agg25/include/agg2/agg_scanline_bin.h:194: warning: unused parameter 
'min_x'
/usr/local/agg25/include/agg2/agg_scanline_bin.h:194: warning: unused parameter 
'max_x'
/usr/local/agg25/include/agg2/agg_rasterizer_sl_clip.h:330: warning: unused 
parameter 'x1'
/usr/local/agg25/include/agg2/agg_rasterizer_sl_clip.h:330: warning: unused 
parameter 'y1'
/usr/local/agg25/include/agg2/agg_rasterizer_sl_clip.h:330: warning: unused 
parameter 'x2'
/usr/local/agg25/include/agg2/agg_rasterizer_sl_clip.h:330: warning: unused 
parameter 'y2'
/usr/local/agg25/include/agg2/agg_bezier_arc.h: In member function 'unsigned 
int agg::bezier_arc::vertex(double*, double*)':
/usr/local/agg25/include/agg2/agg_bezier_arc.h:75: warning: enumeral and 
non-enumeral type in conditional expression
render_handler_agg_style.h: At global scope:
render_handler_agg_style.h:634: warning: unused parameter 'style'
render_handler_agg_style.h:639: warning: unused parameter 'style'
render_handler_agg.cpp: In member function 'void 
gnash::render_handler_agg<PixelFormat>::set_invalidated_regions(const 
gnash::InvalidatedRanges&) [with PixelFormat = 
agg::pixfmt_alpha_blend_rgb<agg::blender_rgb_pre<agg::rgba8, agg::order_rgb>, 
agg::row_accessor<unsigned char> >]':
render_handler_agg.cpp:1908:   instantiated from here
render_handler_agg.cpp:1771: warning: comparison between signed and unsigned 
integer expressions
/usr/local/agg25/include/agg2/agg_image_accessors.h: In member function 'const 
agg::int8u* agg::image_accessor_clone<PixFmt>::span(int, int, unsigned int) 
[with PixFmt = agg::pixfmt_alpha_blend_rgba<agg::blender_rgba_pre<agg::rgba8, 
agg::order_rgba>, agg::row_accessor<unsigned char>, unsigned int>]':
/usr/local/agg25/include/agg2/agg_span_image_filter_rgba.h:153:   instantiated 
from 'void agg::span_image_filter_rgba_bilinear<Source, 
Interpolator>::generate(typename Source::color_type*, int, int, unsigned int) 
[with Source = 
agg::image_accessor_clone<agg::pixfmt_alpha_blend_rgba<agg::blender_rgba_pre<agg::rgba8,
 agg::order_rgba>, agg::row_accessor<unsigned char>, unsigned int> >, 
Interpolator = agg::span_interpolator_linear_subdiv<agg::trans_affine, 8u>]'
render_handler_agg_style.h:139:   instantiated from 'void 
gnash::agg_style_bitmap<PixelFormat, span_allocator_type, img_source_type, 
interpolator_type, sg_type>::generate_span(agg::rgba8*, int, int, unsigned int) 
[with PixelFormat = 
agg::pixfmt_alpha_blend_rgba<agg::blender_rgba_pre<agg::rgba8, 
agg::order_rgba>, agg::row_accessor<unsigned char>, unsigned int>, 
span_allocator_type = 
agg::span_allocator<agg::pixfmt_alpha_blend_rgba<agg::blender_rgba_pre<agg::rgba8,
 agg::order_rgba>, agg::row_accessor<unsigned char>, unsigned int> >, 
img_source_type = 
agg::image_accessor_clone<agg::pixfmt_alpha_blend_rgba<agg::blender_rgba_pre<agg::rgba8,
 agg::order_rgba>, agg::row_accessor<unsigned char>, unsigned int> >, 
interpolator_type = agg::span_interpolator_linear_subdiv<agg::trans_affine, 
8u>, sg_type = 
agg::span_image_filter_rgba_bilinear<agg::image_accessor_clone<agg::pixfmt_alpha_blend_rgba<agg::blender_rgba_pre<agg::rgba8,
 agg::order_rgba>, agg::row_accessor<unsigned char>, unsigne!
 d int> >, agg::span_interpolator_linear_subdiv<agg::trans_affine, 8u> >]'
render_handler_agg.cpp:1908:   instantiated from here
/usr/local/agg25/include/agg2/agg_image_accessors.h:200: warning: comparison 
between signed and unsigned integer expressions
/usr/local/agg25/include/agg2/agg_image_accessors.h: In member function 'const 
agg::int8u* agg::image_accessor_clone<PixFmt>::span(int, int, unsigned int) 
[with PixFmt = agg::pixfmt_alpha_blend_rgb<agg::blender_rgb_pre<agg::rgba8, 
agg::order_rgb>, agg::row_accessor<unsigned char> >]':
/usr/local/agg25/include/agg2/agg_span_image_filter_rgb.h:150:   instantiated 
from 'void agg::span_image_filter_rgb_bilinear<Source, 
Interpolator>::generate(typename Source::color_type*, int, int, unsigned int) 
[with Source = 
agg::image_accessor_clone<agg::pixfmt_alpha_blend_rgb<agg::blender_rgb_pre<agg::rgba8,
 agg::order_rgb>, agg::row_accessor<unsigned char> > >, Interpolator = 
agg::span_interpolator_linear_subdiv<agg::trans_affine, 8u>]'
render_handler_agg_style.h:139:   instantiated from 'void 
gnash::agg_style_bitmap<PixelFormat, span_allocator_type, img_source_type, 
interpolator_type, sg_type>::generate_span(agg::rgba8*, int, int, unsigned int) 
[with PixelFormat = 
agg::pixfmt_alpha_blend_rgb<agg::blender_rgb_pre<agg::rgba8, agg::order_rgb>, 
agg::row_accessor<unsigned char> >, span_allocator_type = 
agg::span_allocator<agg::pixfmt_alpha_blend_rgb<agg::blender_rgb_pre<agg::rgba8,
 agg::order_rgb>, agg::row_accessor<unsigned char> > >, img_source_type = 
agg::image_accessor_clone<agg::pixfmt_alpha_blend_rgb<agg::blender_rgb_pre<agg::rgba8,
 agg::order_rgb>, agg::row_accessor<unsigned char> > >, interpolator_type = 
agg::span_interpolator_linear_subdiv<agg::trans_affine, 8u>, sg_type = 
agg::span_image_filter_rgb_bilinear<agg::image_accessor_clone<agg::pixfmt_alpha_blend_rgb<agg::blender_rgb_pre<agg::rgba8,
 agg::order_rgb>, agg::row_accessor<unsigned char> > >, 
agg::span_interpolator_linear_subdiv<agg::trans_affine,!
  8u> >]'
render_handler_agg.cpp:1908:   instantiated from here
/usr/local/agg25/include/agg2/agg_image_accessors.h:200: warning: comparison 
between signed and unsigned integer expressions
/usr/local/agg25/include/agg2/agg_pixfmt_gray.h: At global scope:
/usr/local/agg25/include/agg2/agg_pixfmt_gray.h: In instantiation of 'static 
void agg::blender_gray<ColorT>::blend_pix(typename ColorT::value_type*, 
unsigned int, unsigned int, unsigned int) [with ColorT = agg::gray8]':
/usr/local/agg25/include/agg2/agg_pixfmt_gray.h:379:   instantiated from 'void 
agg::pixfmt_alpha_blend_gray<Blender, RenBuf, Step, 
Offset>::blend_solid_hspan(int, int, unsigned int, const typename 
Blender::color_type&, const agg::int8u*) [with Blender = 
agg::blender_gray<agg::gray8>, RenBuf = agg::row_accessor<unsigned char>, 
unsigned int Step = 1u, unsigned int Offset = 0u]'
/usr/local/agg25/include/agg2/agg_renderer_base.h:286:   instantiated from 
'void agg::renderer_base<PixelFormat>::blend_solid_hspan(int, int, int, const 
typename PixelFormat::color_type&, const agg::cover_type*) [with PixelFormat = 
agg::pixfmt_alpha_blend_gray<agg::blender_gray<agg::gray8>, 
agg::row_accessor<unsigned char>, 1u, 0u>]'
/usr/local/agg25/include/agg2/agg_renderer_scanline.h:49:   instantiated from 
'void agg::render_scanline_aa_solid(const Scanline&, BaseRenderer&, const 
ColorT&) [with Scanline = agg::scanline_u8, BaseRenderer = 
agg::renderer_base<agg::pixfmt_alpha_blend_gray<agg::blender_gray<agg::gray8>, 
agg::row_accessor<unsigned char>, 1u, 0u> >, ColorT = agg::gray8]'
/usr/local/agg25/include/agg2/agg_renderer_scanline.h:714:   instantiated from 
'void agg::render_scanlines_compound_layered(Rasterizer&, ScanlineAA&, 
BaseRenderer&, SpanAllocator&, StyleHandler&) [with Rasterizer = 
agg::rasterizer_compound_aa<agg::rasterizer_sl_clip<agg::ras_conv_dbl> >, 
ScanlineAA = agg::scanline_u8, BaseRenderer = 
agg::renderer_base<agg::pixfmt_alpha_blend_gray<agg::blender_gray<agg::gray8>, 
agg::row_accessor<unsigned char>, 1u, 0u> >, SpanAllocator = 
agg::span_allocator<agg::gray8>, StyleHandler = 
gnash::render_handler_agg<PixelFormat>::draw_mask_shape_impl(const 
std::vector<gnash::path, std::allocator<gnash::path> >&, int, 
scanline_type&)::sh_type]'
render_handler_agg.cpp:1501:   instantiated from 'void 
gnash::render_handler_agg<PixelFormat>::draw_mask_shape_impl(const 
std::vector<gnash::path, std::allocator<gnash::path> >&, int, scanline_type&) 
[with scanline_type = agg::scanline_u8, PixelFormat = 
agg::pixfmt_alpha_blend_rgb<agg::blender_rgb_pre<agg::rgba8, agg::order_rgb>, 
agg::row_accessor<unsigned char> >]'
render_handler_agg.cpp:1406:   instantiated from 'void 
gnash::render_handler_agg<PixelFormat>::draw_mask_shape(const 
std::vector<gnash::path, std::allocator<gnash::path> >&, int) [with PixelFormat 
= agg::pixfmt_alpha_blend_rgb<agg::blender_rgb_pre<agg::rgba8, agg::order_rgb>, 
agg::row_accessor<unsigned char> >]'
render_handler_agg.cpp:905:   instantiated from 'void 
gnash::render_handler_agg<PixelFormat>::draw_shape_character(gnash::shape_character_def*,
 const gnash::matrix&, const gnash::cxform&, float, const 
std::vector<gnash::fill_style, std::allocator<gnash::fill_style> >&, const 
std::vector<gnash::line_style, std::allocator<gnash::line_style> >&) [with 
PixelFormat = agg::pixfmt_alpha_blend_rgb<agg::blender_rgb_pre<agg::rgba8, 
agg::order_rgb>, agg::row_accessor<unsigned char> >]'
render_handler_agg.cpp:1908:   instantiated from here
/usr/local/agg25/include/agg2/agg_pixfmt_gray.h:53: warning: unused parameter 
'cover'
if /bin/sh ../libtool --tag=CXX --mode=compile g++ -DHAVE_CONFIG_H -I. -I. -I.. 
 -I.. -I.. -I../server -I../server/parser -I../libbase -I../backend 
-I../libgeometry -pthread -I/usr/include/SDL -I/usr/include/pango-1.0 
-I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include   -I/usr/include/glib-2.0 
-I/usr/lib/glib-2.0/include    -I/usr/include/atk-1.0 -I/usr/include/glib-2.0 
-I/usr/lib/glib-2.0/include              -I/usr/local/agg25/include/agg2   -g 
-O2 -pthread -march=athlon64     -W     -Wall     -Wcast-align     -Wcast-qual  
   -Wpointer-arith     -Wreturn-type      -MT sound_handler.lo -MD -MP -MF 
".deps/sound_handler.Tpo" -c -o sound_handler.lo sound_handler.cpp; \
        then mv -f ".deps/sound_handler.Tpo" ".deps/sound_handler.Plo"; else rm 
-f ".deps/sound_handler.Tpo"; exit 1; fi
/usr/local/agg25/include/agg2/agg_gradient_lut.h: In member function 'void 
agg::gradient_lut<ColorInterpolator, ColorLutSize>::build_lut() [with 
ColorInterpolator = agg::color_interpolator<agg::rgba8>, unsigned int 
ColorLutSize = 256u]':
/usr/local/agg25/include/agg2/agg_gradient_lut.h:222: warning: 'end' may be 
used uninitialized in this function
 g++ -DHAVE_CONFIG_H -I. -I. -I.. -I.. -I.. -I../server -I../server/parser 
-I../libbase -I../backend -I../libgeometry -pthread -I/usr/include/SDL 
-I/usr/include/pango-1.0 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include 
-I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/atk-1.0 
-I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include 
-I/usr/local/agg25/include/agg2 -g -O2 -pthread -march=athlon64 -W -Wall 
-Wcast-align -Wcast-qual -Wpointer-arith -Wreturn-type -MT sound_handler.lo -MD 
-MP -MF .deps/sound_handler.Tpo -c sound_handler.cpp  -fPIC -DPIC -o 
.libs/sound_handler.o
/usr/local/agg25/include/agg2/agg_conv_curve.h: In member function 'unsigned 
int agg::conv_curve<VertexSource, Curve3, Curve4>::vertex(double*, double*) 
[with VertexSource = agg::path_base<agg::vertex_block_storage<double, 8u, 256u> 
>, Curve3 = agg::curve3, Curve4 = agg::curve4]':
/usr/local/agg25/include/agg2/agg_conv_curve.h:165: warning: 'end_y' may be 
used uninitialized in this function
/usr/local/agg25/include/agg2/agg_conv_curve.h:164: warning: 'end_x' may be 
used uninitialized in this function
/usr/local/agg25/include/agg2/agg_conv_curve.h:163: warning: 'ct2_y' may be 
used uninitialized in this function
/usr/local/agg25/include/agg2/agg_conv_curve.h:162: warning: 'ct2_x' may be 
used uninitialized in this function