Re: [Gnash-dev] link with all the libraries providing symbols

[Bastiaan Jacques]

On Saturday 15 July 2006 22:24, Patrice Dumas wrote:
> Index: gui/Makefile.am
> ===================================================================
> RCS file: /sources/gnash/gnash/gui/Makefile.am,v
> retrieving revision 1.6
> diff -u -3 -p -r1.6 Makefile.am
> --- gui/Makefile.am     17 May 2006 08:51:17 -0000      1.6
> +++ gui/Makefile.am     15 Jul 2006 19:52:09 -0000
> @@ -52,14 +52,14 @@ endif # ! USE_RENDERER_OPENGL
>  
>  if USE_RENDERER_CAIRO
>  GTK_CAIRO_SRCS = gtk_glue_cairo.cpp gtk_glue_cairo.h
> -KDE_CAIRO_SRCS = kde_glue_cairo.cpp kde_glue_cairo.h
> +KDE_CAIRO_SRCS = #kde_glue_cairo.cpp kde_glue_cairo.h

These files will hopefully exist before the next release. I don't see 
much point in commenting those lines out now.

> Index: libbase/Makefile.am
> ===================================================================
> RCS file: /sources/gnash/gnash/libbase/Makefile.am,v
> retrieving revision 1.30
> diff -u -3 -p -r1.30 Makefile.am
> --- libbase/Makefile.am 7 Jun 2006 03:03:22 -0000       1.30
> +++ libbase/Makefile.am 15 Jul 2006 19:52:09 -0000
> @@ -94,8 +94,8 @@ libgnashbase_la_LIBADD = \
>         $(JPEG_LIBS) \
>         $(ZLIB_LIBS) \
>         $(CURL_LIBS) \
> -       $(SDL_LIBS)
> -#      $(OPENGL_LIBS)
> +       $(SDL_LIBS) \
> +       $(OPENGL_LIBS)

I'm a bit reluctant to commit this, because of this earlier commit by 
rsavoye:

* libbase/Makefile.am: Remove OPENGL_LIBS from _LIBADD, it causes
        OpenGL to hang on my Ubuntu system.

The other hunks look reasonable to me.

Bastiaan