Re: [Gnash-commit] [patch #9016] Improved handling of gstreamer plugin installation returns

[Dag Hovland]

Yes, you're right. Thanks. The free should have been in one of the other 
error handling blocks. I will upload a new patch.

Dag

Den 17. juli 2016 03:18, skrev Richard Wilbur:
> A few comments:
>
> gui/Player.cpp:  Player::run() in comment
> s/gstremer/gstreamer/
>
> libmedia/gst/GstUtil.cpp:
> @@ -121,31 +143,118 @@ GstUtil::check_missing_plugins(GstCaps* caps)
>
> I've got a question here:  Doesn't "if (!detail)" imply that detail is
> NULL?  If so, does it seem appropriate to call "g_free(detail)"?
>
> Later in same hunk in comment above GstUtil::plugin_success_dialog():
> replace "where successully installed" with "were successfully installed."
>
> libmedia/gst/GstUtil.h:
> @@ -73,12 +78,35 @@ public:
> in comments
> s/poping/popping/
> s/Protcts/Protects/
> s/diaplog/dialog/