gnash-commit
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Gnash-commit] [patch #9016] Improved handling of gstreamer plugin i


From: Richard Wilbur
Subject: Re: [Gnash-commit] [patch #9016] Improved handling of gstreamer plugin installation returns
Date: Sat, 16 Jul 2016 19:18:19 -0600

A few comments:

gui/Player.cpp:  Player::run() in comment
s/gstremer/gstreamer/

libmedia/gst/GstUtil.cpp:
@@ -121,31 +143,118 @@ GstUtil::check_missing_plugins(GstCaps* caps)

I've got a question here:  Doesn't "if (!detail)" imply that detail is
NULL?  If so, does it seem appropriate to call "g_free(detail)"?

Later in same hunk in comment above GstUtil::plugin_success_dialog():
replace "where successully installed" with "were successfully installed."

libmedia/gst/GstUtil.h:
@@ -73,12 +78,35 @@ public:
in comments
s/poping/popping/
s/Protcts/Protects/
s/diaplog/dialog/



reply via email to

[Prev in Thread] Current Thread [Next in Thread]