[Gnash-commit] [patch #8723] Patches to improve the unimplemented `TextField.getFontList()` stub

[Nutchanon Wetchasit]

Follow-up Comment #2, patch #8723 (project gnash):

Patch 2 of 2.
See the attached `0002_make-textfield-getfontlist-return-array.patch`.

This patch tries to rectify the problem of `TextField.getFontList()`
returning `undefined` which would cause EFF Panopticlick to fail,
by making it return an empty Array object instead.
(But still printing `UNIMPLEMENTED` log message)

This partially fixes bug #42395.

Note: The code uses `Global_as.createArray()`
<http://git.savannah.gnu.org/cgit/gnash.git/tree/libcore/asobj/Global_as.cpp?id=e04f9e25c68ba879e82d206716eae76fc4542cb8#n206>
to create an empty Array,
which is the same way as used in `String.split()`
<http://git.savannah.gnu.org/cgit/gnash.git/tree/libcore/asobj/String_as.cpp?id=e04f9e25c68ba879e82d206716eae76fc4542cb8#n235>.

The patch has a side effect of allowing proper automated test to be done
on the method. Originally, there was no way to know whether this
UNIMPLEMENTED
method call succeeded or failed from ActionScript; both cases returned the
same `undefined` value and exception handler didn't help. With this patch,
successful call returns Array, other values indicate failure.

Automated tests will follow.

Gnash: 0.8.11dev (patched against git e04f9e2 24-Aug-2015)
System: Debian GNU/Linux 7.0 Wheezy i386

(file #34724)
    _______________________________________________________

Additional Item Attachment:

File name: 0002_make-textfield-getfontlist-return-array.patch Size:0 KB


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/patch/?8723>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/