[Gnash-commit] [patch #8723] Patches to improve the unimplemented `TextField.getFontList()` stub

[Nutchanon Wetchasit]

URL:
  <http://savannah.gnu.org/patch/?8723>

                 Summary: Patches to improve the unimplemented
`TextField.getFontList()` stub
                 Project: Gnash - The GNU Flash player
            Submitted by: nachanon
            Submitted on: Mon 24 Aug 2015 03:09:10 PM ICT
                Category: ActionScript
                Priority: 5 - Normal
                  Status: None
                 Privacy: Public
             Assigned to: None
        Originator Email: 
             Open/Closed: Open
         Discussion Lock: Any

    _______________________________________________________

Details:

Currently Gnash's `TextField.getFontList()` method placeholder code have
a problem that caused ActionScript error
<https://savannah.gnu.org/bugs/?42395#comment3> when it was called:

ACTIONSCRIPT ERROR: ActionCallMethod: Function requiring gnash::TextField* as
'this' called from gnash::as_object* instance.


This seems to be caused by a `this` pointer check
<http://git.savannah.gnu.org/cgit/gnash.git/tree/libcore/asobj/TextField_as.cpp?id=88f86a3c63171283388f3644008763f2e6ab851b#n594>
at the method's start
which is incorrect, since `TextField.getFontList()` is a static method;
`this` is not supposed to be available.

Attached patch (patch 1 of 2:
`0001_remove-textfield-getfontlist-this-ptr-check.patch`)
tries to rectify the problem by removing the check;
partially fixing bug #42395.

This might need a review before I submit the second patch, since I have seen
two approach of handling this in static method, one in `Math` class
<http://git.savannah.gnu.org/cgit/gnash.git/tree/libcore/asobj/Math_as.cpp?id=88f86a3c63171283388f3644008763f2e6ab851b#n154>
(used by this patch), different way can be seen in `Camera` class
<http://git.savannah.gnu.org/cgit/gnash.git/tree/libcore/asobj/Camera_as.cpp?id=88f86a3c63171283388f3644008763f2e6ab851b#n242>.

Gnash: 0.8.11dev (patched against git 88f86a3 19-Aug-2015 on top of patch
#8721)
System: Debian GNU/Linux 7.0 Wheezy i386




    _______________________________________________________

File Attachments:


-------------------------------------------------------
Date: Mon 24 Aug 2015 03:09:10 PM ICT  Name:
0001_remove-textfield-getfontlist-this-ptr-check.patch  Size: 596B   By:
nachanon
Patch to remove incorrect `this` pointer check in TextField.getFontList()
<http://savannah.gnu.org/patch/download.php?file_id=34708>

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/patch/?8723>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/