|
| From: | Bastiaan Jacques |
| Subject: | Re: [Gnash-commit] [SCM] Gnash branch, master, updated. release_0_8_9_final-2127-g2e5e573 |
| Date: | Tue, 10 Jun 2014 13:02:05 +0200 (CEST) |
| User-agent: | Alpine 2.00 (DEB 1167 2008-08-23) |
On Tue, 10 Jun 2014, Sandro Santilli wrote:
commit 2e5e5737faca9936e6a8645e69b380dddc52bf61 Author: Bastiaan Jacques <address@hidden> Date: Tue Jun 10 11:45:28 2014 +0200 Switch the GcResource container type to forward_list. We don't make use of bidirectional access, so a singly linked list is adequate. The order of elements seems to be irrelevant, so it doesn't matter that we now push elements at the front rather than the back.I think the reason to push at the front and pop from the back was the possible concurrent access to that list by different threads.
So far as I'm aware there is no popping at all. (Instead, cleanUnreachable simply iterates the whole list.) Please correct me if I'm wrong. Further, I would be surprised if the described method of read/writing a std::list actually provides thread safety. Still, it seems like a good idea to make sure that either GcResources are not created by threads other than the main thread, or that GC becomes thread-safe. Bastiaan
| [Prev in Thread] | Current Thread | [Next in Thread] |