|
| From: | Bastiaan Jacques |
| Subject: | Re: [Gnash-commit] [SCM] Gnash branch, master, updated. release_0_8_9_final-2092-g36b1a2f |
| Date: | Mon, 2 Jun 2014 19:30:46 +0200 (CEST) |
| User-agent: | Alpine 2.00 (DEB 1167 2008-08-23) |
On Sun, 1 Jun 2014, Richard Wilbur wrote:
template<class T> -tree_node_<T>::tree_node_(const T& val) - : parent(nullptr), first_child(nullptr), last_child(nullptr), prev_sibling(nullptr), next_sibling(nullptr), data(val) +tree_node_<T>::tree_node_(const T val) + : parent(nullptr), first_child(nullptr), last_child(nullptr), prev_sibling(nullptr), next_sibling(nullptr), data(std::move(val))In all the other cases, when you removed the reference, you also removed the 'const' declaration. Here, in tree_node_<T>::tree_node_, you left the 'const' declaration. Why?
Because I simply overlooked it. Well spotted!
I presume the main reason for not changing the other objects presently passed by const reference is that they aren't movable?
Only one object is passed to this particular constructor, that I can see. Bastiaan
| [Prev in Thread] | Current Thread | [Next in Thread] |