[Gnash-commit] [SCM] Gnash branch, master, updated. release_0_8_9_final-1934-ge71eea1

[Petter Reinholdtsen]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Gnash".

The branch, master has been updated
       via  e71eea13cbdaa7991c2883f971280f6dfdbee208 (commit)
       via  623ee5feda3b3456155bb4651e940c5461ab0ad0 (commit)
       via  930e1f77e5c01bc09d0a21b621656e42d177be2e (commit)
       via  c0e784b627d0c61755a5cd59be54cf8296bd9a72 (commit)
       via  81b6b1748c2b3687278b2aba459ffee48a3a5ef5 (commit)
      from  a13911f51f6fa34776220aaa749a5aa60e8e129d (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
http://git.savannah.gnu.org/cgit//commit/?id=e71eea13cbdaa7991c2883f971280f6dfdbee208


commit e71eea13cbdaa7991c2883f971280f6dfdbee208
Author: Petter Reinholdtsen <address@hidden>
Date:   Thu Apr 24 15:12:09 2014 +0200

    Make sure to initialize all Qt4Gui member variables in constructor 
(Coverity CID 1149266).

diff --git a/gui/qt/Qt4Gui.cpp b/gui/qt/Qt4Gui.cpp
index 45006fd..29f9e07 100644
--- a/gui/qt/Qt4Gui.cpp
+++ b/gui/qt/Qt4Gui.cpp
@@ -83,8 +83,23 @@ Qt4Gui::Qt4Gui(unsigned long xid, float scale, bool loop, 
RunResources& r)
     :
     Gui(xid, scale, loop, r),
     _numArgs(0),
+    _embedWidget(NULL),
+    _drawingWidget(NULL),
     _interval(0),
     _advanceTimer(0)
+    , fileMenu(NULL)
+    , propertiesAction(NULL)
+    , quitAction(NULL)
+    , editMenu(NULL)
+    , preferencesAction(NULL)
+    , movieControlMenu(NULL)
+    , playAction(NULL)
+    , pauseAction(NULL)
+    , stopAction(NULL)
+    , restartAction(NULL)
+    , viewMenu(NULL)
+    , refreshAction(NULL)
+    , fullscreenAction(NULL)
 {
 }
 

http://git.savannah.gnu.org/cgit//commit/?id=623ee5feda3b3456155bb4651e940c5461ab0ad0


commit 623ee5feda3b3456155bb4651e940c5461ab0ad0
Author: Petter Reinholdtsen <address@hidden>
Date:   Thu Apr 24 15:04:03 2014 +0200

    Make sure to initialize SdlCairoGlue all private member variables
    in constructor (Coverity CID 1149299).

diff --git a/gui/sdl/sdl_cairo_glue.cpp b/gui/sdl/sdl_cairo_glue.cpp
index 5007bb7..1fd8f98 100644
--- a/gui/sdl/sdl_cairo_glue.cpp
+++ b/gui/sdl/sdl_cairo_glue.cpp
@@ -27,6 +27,12 @@ namespace gnash
 {
 
 SdlCairoGlue::SdlCairoGlue()
+: _cairo_surface(NULL)
+  , _cairo_handle(NULL)
+  , _sdl_surface(NULL)
+  , _render_image(NULL)
+  , _screen(NULL)
+  , _renderer(NULL)
 {
 //    GNASH_REPORT_FUNCTION;
 }

http://git.savannah.gnu.org/cgit//commit/?id=930e1f77e5c01bc09d0a21b621656e42d177be2e


commit 930e1f77e5c01bc09d0a21b621656e42d177be2e
Author: Petter Reinholdtsen <address@hidden>
Date:   Thu Apr 24 14:54:24 2014 +0200

    Update comment and document CID # too for code that trigger compiler
    warning for Range2d template when used with an unsigned type.

diff --git a/libbase/Range2d.h b/libbase/Range2d.h
index d0a07c0..439004a 100644
--- a/libbase/Range2d.h
+++ b/libbase/Range2d.h
@@ -513,7 +513,9 @@ public:
        {
                if ( isNull() || isWorld() || amount==0 ) return *this;
 
-               // NOTE: triggers a compiler warning when T is an unsigned type
+               // NOTE: this trigger a compiler warning when T is an
+               //       unsigned type (Coverity CID 1154656 -
+               //       logically dead code)
                if ( amount < 0 ) return shrinkBy(-amount);
 
                T newxmin = _xmin - amount;
@@ -564,8 +566,9 @@ public:
        {
                if ( isNull() || isWorld() || amount==0 ) return *this;
 
-               // NOTE: whith will likely trigger a compiler
-               //       warning when T is an unsigned type
+               // NOTE: this trigger a compiler warning when T is an
+               //       unsigned type (Coverity CID 1154655 -
+               //       logically dead code)
                if ( amount < 0 ) return growBy(-amount);
 
                // Turn this range into the NULL range

http://git.savannah.gnu.org/cgit//commit/?id=c0e784b627d0c61755a5cd59be54cf8296bd9a72


commit c0e784b627d0c61755a5cd59be54cf8296bd9a72
Author: Petter Reinholdtsen <address@hidden>
Date:   Thu Apr 24 14:47:19 2014 +0200

    Make sure to initialize Range2d member variables _ymin and _ymax to zero 
also for the 'world' and 'null' ranges, to have well known values even if they 
are unused (Coverity CID 1155095).

diff --git a/libbase/Range2d.h b/libbase/Range2d.h
index d5df21b..d0a07c0 100644
--- a/libbase/Range2d.h
+++ b/libbase/Range2d.h
@@ -183,6 +183,8 @@ public:
        {
                _xmin = std::numeric_limits<T>::max();
                _xmax = std::numeric_limits<T>::min();
+               _ymin = 0;
+               _ymax = 0;
                return *this;
        }
 
@@ -215,6 +217,8 @@ public:
        {
                _xmin = std::numeric_limits<T>::min();
                _xmax = std::numeric_limits<T>::max();
+               _ymin = 0;
+               _ymax = 0;
                return *this;
        }
 

http://git.savannah.gnu.org/cgit//commit/?id=81b6b1748c2b3687278b2aba459ffee48a3a5ef5


commit 81b6b1748c2b3687278b2aba459ffee48a3a5ef5
Author: Petter Reinholdtsen <address@hidden>
Date:   Thu Apr 24 14:45:55 2014 +0200

    Fix typo in documentation (minimun->minimum, maximun->maximum).

diff --git a/libbase/Range2d.h b/libbase/Range2d.h
index c1cac0b..d5df21b 100644
--- a/libbase/Range2d.h
+++ b/libbase/Range2d.h
@@ -204,7 +204,7 @@ public:
 
        /// Set the Range2d to the WORLD value
        //
-       /// This is implemented using the minimun and maximun
+       /// This is implemented using the minimum and maximum
        /// values of the parameter type.
        ///
        /// See RangeType::worldRange

-----------------------------------------------------------------------

Summary of changes:
 gui/qt/Qt4Gui.cpp          |   15 +++++++++++++++
 gui/sdl/sdl_cairo_glue.cpp |    6 ++++++
 libbase/Range2d.h          |   15 +++++++++++----
 3 files changed, 32 insertions(+), 4 deletions(-)


hooks/post-receive
-- 
Gnash