[Gnash-commit] [SCM] Gnash branch, master, updated. release_0_8_9_final-1929-ga13911f

[Petter Reinholdtsen]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Gnash".

The branch, master has been updated
       via  a13911f51f6fa34776220aaa749a5aa60e8e129d (commit)
       via  79fdb637534f781448bd165abc8b009b40e24b9f (commit)
       via  a55b9b9b60e973bc33210a5334262bd5d09dbeb9 (commit)
      from  1bfc147444992f18d4015f4c9da264fc56b9f274 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
http://git.savannah.gnu.org/cgit//commit/?id=a13911f51f6fa34776220aaa749a5aa60e8e129d


commit a13911f51f6fa34776220aaa749a5aa60e8e129d
Author: Petter Reinholdtsen <address@hidden>
Date:   Thu Apr 24 14:30:37 2014 +0200

    Detect and log error if dup(0) fail in StreamProvider::getStream() 
(Coverity CID 1149170).

diff --git a/libbase/StreamProvider.cpp b/libbase/StreamProvider.cpp
index 0e3efb3..8204089 100644
--- a/libbase/StreamProvider.cpp
+++ b/libbase/StreamProvider.cpp
@@ -69,7 +69,13 @@ StreamProvider::getStream(const URL& url, bool 
namedCacheFile) const
             //       Note also that the FB gui will use stdin
             //       for key events.
             //
-                       FILE *newin = fdopen(dup(0), "rb");
+                       int fd = dup(0);
+                       if (0 > fd) {
+                               log_error(_("Could not stdin (filename -): 
%2%"),
+                                         std::strerror(errno));
+                               return stream;
+                       }
+                       FILE *newin = fdopen(fd, "rb");
 
                        // Close on destruction.
                        stream = makeFileChannel(newin, true);

http://git.savannah.gnu.org/cgit//commit/?id=79fdb637534f781448bd165abc8b009b40e24b9f


commit 79fdb637534f781448bd165abc8b009b40e24b9f
Author: Petter Reinholdtsen <address@hidden>
Date:   Thu Apr 24 14:11:21 2014 +0200

    Fix code to find user home directory to actually fetch the value
    from getpwuid() if $HOME is unset (Coverity CID 1149119).

diff --git a/libbase/rc.cpp b/libbase/rc.cpp
index 5192792..1ff2ab9 100644
--- a/libbase/rc.cpp
+++ b/libbase/rc.cpp
@@ -303,7 +303,7 @@ RcInitFile::expandPath (std::string& path)
             else { 
                 struct passwd *password = getpwuid(getuid());
                     const char *pwdhome = password->pw_dir;
-                    if (home) {
+                    if (pwdhome) {
                         path.replace(0, 1, pwdhome);
                     }
                    //If all that fails, leave path alone

http://git.savannah.gnu.org/cgit//commit/?id=a55b9b9b60e973bc33210a5334262bd5d09dbeb9


commit a55b9b9b60e973bc33210a5334262bd5d09dbeb9
Author: Petter Reinholdtsen <address@hidden>
Date:   Thu Apr 24 14:08:11 2014 +0200

    Only provide  SharedLib::_dlhandle member variable when HAVE_LTDL is 
defined,
    and make sure to initialize it to NULL when it exist (Coverity CID 1149287).

diff --git a/libbase/sharedlib.cpp b/libbase/sharedlib.cpp
index 918bf69..520bea9 100644
--- a/libbase/sharedlib.cpp
+++ b/libbase/sharedlib.cpp
@@ -58,6 +58,9 @@ lt_dlhandle lt_dlopenext       (const char *filename);
 namespace gnash {
 
 SharedLib::SharedLib(const std::string& filespec)
+#ifdef HAVE_LTDL
+  : _dlhandle(NULL)
+#endif
 {
     _filespec = filespec;
     scoped_lock lock(_libMutex);
diff --git a/libbase/sharedlib.h b/libbase/sharedlib.h
index 8c82371..c4dc20c 100644
--- a/libbase/sharedlib.h
+++ b/libbase/sharedlib.h
@@ -68,7 +68,9 @@ private:
 
     bool closeLib();
 
+#ifdef HAVE_LTDL
     lt_dlhandle _dlhandle;
+#endif
     std::string _filespec;
     boost::mutex _libMutex;    
 };

-----------------------------------------------------------------------

Summary of changes:
 libbase/StreamProvider.cpp |    8 +++++++-
 libbase/rc.cpp             |    2 +-
 libbase/sharedlib.cpp      |    3 +++
 libbase/sharedlib.h        |    2 ++
 4 files changed, 13 insertions(+), 2 deletions(-)


hooks/post-receive
-- 
Gnash