[Gnash-commit] [patch #8226] fix cppcheck "Ineffective call" report

[Julien Nabet]

URL:
  <http://savannah.gnu.org/patch/?8226>

                 Summary: fix cppcheck "Ineffective call" report
                 Project: Gnash - The GNU Flash player
            Submitted by: julien2412
            Submitted on: mar. 29 oct. 2013 22:32:24 GMT
                Category: None
                Priority: 5 - Normal
                  Status: None
                 Privacy: Public
             Assigned to: None
        Originator Email: 
             Open/Closed: Open
         Discussion Lock: Any

    _______________________________________________________

Details:

Hello,

Cppcheck reported this:
[gui/qt/Qt4Gui.cpp:510]: (warning) Ineffective call of function 'empty()'. Did
you intend to call 'clear()' instead?
Indeed, we've got this:
    507         if (newDepth == 0) {
    508             // Insert top level entries directly into the tree
widget.
    509             items.append(item);
    510             stack.empty();
    511         } else {

I attached a straightforward patch.

Julien



    _______________________________________________________

File Attachments:


-------------------------------------------------------
Date: mar. 29 oct. 2013 22:32:24 GMT  Name: Qt4Gui_patch.txt  Size: 480 o  
By: julien2412

<http://savannah.gnu.org/patch/download.php?file_id=29503>

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/patch/?8226>

_______________________________________________
  Message posté via/par Savannah
  http://savannah.gnu.org/