[Gnash-commit] [patch #8225] fix cppcheck reports for memtest.cpp

[Julien Nabet]

URL:
  <http://savannah.gnu.org/patch/?8225>

                 Summary: fix cppcheck reports for memtest.cpp
                 Project: Gnash - The GNU Flash player
            Submitted by: julien2412
            Submitted on: mar. 29 oct. 2013 19:23:13 GMT
                Category: testsuite
                Priority: 5 - Normal
                  Status: None
                 Privacy: Public
             Assigned to: None
        Originator Email: 
             Open/Closed: Open
         Discussion Lock: Any

    _______________________________________________________

Details:

Hello,

On git gnash sources retrieved today, cppcheck reported this:
[testsuite/libbase.all/memtest.cpp:53]: (style) Variable 'diff' is assigned a
value that is never used.
[testsuite/libbase.all/memtest.cpp:98]: (style) Variable 'x' is allocated
memory that is never used.
[testsuite/libbase.all/memtest.cpp:80]: (warning) Logical disjunction always
evaluates to true: diff >= 8 || diff <= 16.

I attached a patch for fixing them.

Julien



    _______________________________________________________

File Attachments:


-------------------------------------------------------
Date: mar. 29 oct. 2013 19:23:13 GMT  Name: memtest_patch.cpp  Size: 1 ko  
By: julien2412

<http://savannah.gnu.org/patch/download.php?file_id=29502>

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/patch/?8225>

_______________________________________________
  Message posté via/par Savannah
  http://savannah.gnu.org/