Re: [Gnash-commit] [patch #8086] RTMP netStream patch

[Sandro Santilli]

On Wed, Jul 31, 2013 at 07:04:15PM +0530, George Thomas wrote:
> On Wed, Jul 31, 2013 at 6:03 PM, Sandro Santilli <address@hidden> wrote:
> > On Wed, Jul 31, 2013 at 11:52:16AM +0000, George Thomas wrote:
> >> Follow-up Comment #6, patch #8086 (project gnash):
> >>
> >> Ran the regressing with the source checked out today. Could not find any
> >> regressions when tested with and without rtmp2.patch
> >>
> >> As regressions are absent is this good enough to go in or what work would 
> >> have
> >> to be done to ensure that the patch is better?
> >
> > You should add a test showing that the patch is needed.
> > The test would fail without the patch and succeed with it.
> > The test should be self-contained, so that it is easier for
> > anyone to verify its expectances are correct by running it
> > with the proprietary player.
> >
> 
> What I used was red5 running locally to test it. Then used
> "make oflaDemo.swf" to make the swf and then ran with gnash.
> 
> I found an option --enable-red5-testing=<host>.
> Should the tests be written in such a way that they become
> active with the option ?

Yes please.
IIRC we had a red5 server running on gnashdev.org for specifically
these kind of tests too. Rob, is that still running ?

--strk;