Re: [Gnash-commit] [patch #8086] RTMP netStream patch

[Sandro Santilli]

On Wed, Jul 31, 2013 at 11:52:16AM +0000, George Thomas wrote:
> Follow-up Comment #6, patch #8086 (project gnash):
> 
> Ran the regressing with the source checked out today. Could not find any
> regressions when tested with and without rtmp2.patch
> 
> As regressions are absent is this good enough to go in or what work would have
> to be done to ensure that the patch is better?

You should add a test showing that the patch is needed.
The test would fail without the patch and succeed with it.
The test should be self-contained, so that it is easier for
anyone to verify its expectances are correct by running it
with the proprietary player.

> I was getting these failures in both cases. 
> 
...
> Unexpected failures follow:
>  --=[ testsuite/actionscript.all ]=-- 
> FAIL: astests-v6-Runner: no onSoundComplete arrived after 3 seconds
> FAIL: astests-v6-Runner: Tests run 107 (expected 112) [
> [../../../gnash/testsuite/actionscript.all/Sound.as:31]]
> FAIL: astests-v7-Runner: no onSoundComplete arrived after 3 seconds
> FAIL: astests-v7-Runner: Tests run 107 (expected 112) [
> [../../../gnash/testsuite/actionscript.all/Sound.as:31]]
> FAIL: astests-v8-Runner: no onSoundComplete arrived after 3 seconds
> FAIL: astests-v8-Runner: Tests run 107 (expected 112) [
> [../../../gnash/testsuite/actionscript.all/Sound.as:31]]
> 
> Could not understand why these were happening.

I believe these are due to using GST media handler rather than FFMPEG, can
you confirm ?

--strk;