Re: [Gnash-commit] [SCM] Gnash branch, master, updated. release_0_8_9_start-66-g17d5a9b

[strk]

On Tue, Feb 15, 2011 at 02:19:15AM +0000, Gabriele Giacone wrote:

> diff --git a/macros/kde4.m4 b/macros/kde4.m4
> index 2825877..8b16768 100644
> --- a/macros/kde4.m4
> +++ b/macros/kde4.m4
> @@ -192,31 +192,23 @@ AC_DEFUN([GNASH_PATH_KDE4],
>      fi
>  
>      if test x"${with_kde4_plugindir}" != x ; then 
> -      if test -d ${with_kde4_plugindir}/lib64; then
> -        KDE4_PLUGINDIR="${with_kde4_plugindir}/lib64/kde4"
> -      else
> -        KDE4_PLUGINDIR="${with_kde4_plugindir}/lib/kde4"
> -      fi
> +      KDE4_PLUGINDIR="${with_kde4_plugindir}"

+1

>      else
> -      if test -d ${KDE4_PREFIX}/lib64; then
> +      if test -d ${KDE4_PREFIX}/lib64 -a ! -h ${KDE4_PREFIX}/lib64; then
>          KDE4_PLUGINDIR="${KDE4_PREFIX}/lib64/kde4"
>        else
>          KDE4_PLUGINDIR="${KDE4_PREFIX}/lib/kde4"
>        fi
>      fi

This is suspicious.
You do strong checking against lib64/kde4
and no checking at all for lib/kde4 ...

What if lib64/kde4 is the only existing one, symlinking who knows where ?

--strk;

  ()   Free GIS & Flash consultant/developer
  /\   http://strk.keybit.net/services.html