Re: [Gnash-commit] /srv/bzr/gnash/trunk r12349: Silence some debugging messages.

[Rob Savoye]

On 08/04/10 10:42, Benjamin Wolsey wrote:

> If I were you I'd find out what causes the crash before jumping to
> conclusions. As I said, you are welcome to revert the hwaccel changes

  I'm not jumping to conclusions, all I said is that trunk is now
broken. Maybe I picked the wrong post to reply to. Considering how much
shit I got a while ago, I find this breakage slightly amusing...

> A more likely cause is that the GnashImage class changed, and the vaapi
> code rather inadvisably uses a subclass of GnashImage. I adapted the
> GnashVaapiImage without being able to test it.

  Changing code you can't test is often a mistake... If I did this, I'd
never hear the end of it... If this is the cause, then I'm gonna disable
vaapi, as libva & ffmpeg aren't in many distros quite yet anyway. Nobody
but developers can use it anyway. My gut feeling is the Bitmap changes
will be more useful to end users for this release than vaapi anyway. I
probably need to refactor all the vaapi code anyway to work with
OpenVG/OpenGLES. (not for this release obviously) So I probably won't
make this a blocker, but need to look into it to see the real cause.
Maybe it's an easy fix, or maybe it's not...

  Were you testing this with ATI, Nvidia, or an Intel GPU ? Were you
using the packages in our repo, or a distribution one ?

        - rob -