[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Gnash-commit] /srv/bzr/gnash/trunk r10288: Rewrite XML parsing.
|
From: |
Benjamin Wolsey |
|
Subject: |
Re: [Gnash-commit] /srv/bzr/gnash/trunk r10288: Rewrite XML parsing. |
|
Date: |
Thu, 20 Nov 2008 08:16:47 +0100 |
Am Mittwoch, den 19.11.2008, 19:35 -0800 schrieb Bastiaan Jacques:
> On Tue, 18 Nov 2008, Benjamin Wolsey wrote:
>
> >+ if (static_cast<size_t>(end - it) < len) return false;
>
> Nit: would std::distance be more appropriate here?
>
If I remember correctly, std::distance is more appropriate for comparing
different types of iterators; where a simple comparison is possible it's
better to do that. I'm open to persuasion, though.
--
Yes, YouTube does work in Gnash
http://www.gnu.org/software/gnash/
Benjamin Wolsey, Software Developer - http://benjaminwolsey.de
signature.asc
Description: Dies ist ein digital signierter Nachrichtenteil