Re: [Gnash-commit] /srv/bzr/gnash/trunk r10288: Rewrite XML parsing.

[Bastiaan Jacques]

On Tue, 18 Nov 2008, Benjamin Wolsey wrote:

> +    if (static_cast<size_t>(end - it) < len) return false;

Nit: would std::distance be more appropriate here?

Bastiaan


> ------------------------------------------------------------
> revno: 10288
> committer: Benjamin Wolsey <address@hidden>
> branch nick: trunk
> timestamp: Tue 2008-11-18 11:18:05 +0100
> message:
>  Rewrite XML parsing.
> removed:
>  libcore/asobj/xmlattrs.cpp
>  macros/libXML.m4
> modified:
>  configure.ac
>  libcore/asobj/Makefile.am
>  libcore/asobj/XMLNode_as.cpp
>  libcore/asobj/XMLNode_as.h
>  libcore/asobj/XML_as.cpp
>  libcore/asobj/XML_as.h
>  libcore/asobj/xmlattrs.h
>  testsuite/actionscript.all/XML.as
>  testsuite/swfdec/PASSING
>    ------------------------------------------------------------
>    revno: 10285.1.1
>    committer: Benjamin Wolsey <address@hidden>
>    branch nick: test
>    timestamp: Tue 2008-11-18 10:29:12 +0100
>    message:
>      Rewrite XML parsing, using swfdec's model as a base.
>
>      This:
>      - removes the dependency on libxml2
>      - is less strict, so that we can parse XML incorrectly like Flash does
>      - and consequently fixes many cases where an unescaped entity broke parsing
>        completely.
>      - parses directly into XMLNodes instead of first into memory
>      - passes some more swfdec tests.
>
>      Drop various unused functions and files. Rename enums to make it less ugly.
>      Clean up.
>
>      Remove libxml checks from configure.
>    removed:
>      libcore/asobj/xmlattrs.cpp
>      macros/libXML.m4
>    modified:
>      configure.ac
>      libcore/asobj/Makefile.am
>      libcore/asobj/XMLNode_as.cpp
>      libcore/asobj/XMLNode_as.h
>      libcore/asobj/XML_as.cpp
>      libcore/asobj/XML_as.h
>      libcore/asobj/xmlattrs.h
>      testsuite/actionscript.all/XML.as
>    ------------------------------------------------------------
>    revno: 10285.1.2
>    committer: Benjamin Wolsey <address@hidden>
>    branch nick: test
>    timestamp: Tue 2008-11-18 10:34:03 +0100
>    message:
>      Swfdec testsuite passes.
>    modified:
>      testsuite/swfdec/PASSING
>    ------------------------------------------------------------
>    revno: 10285.1.3
>    committer: Benjamin Wolsey <address@hidden>
>    branch nick: test
>    timestamp: Tue 2008-11-18 10:42:06 +0100
>    message:
>      Drop libxml includes from XMLNode_as.h
>    modified:
>      libcore/asobj/XMLNode_as.h
>      libcore/asobj/XML_as.cpp
>    ------------------------------------------------------------
>    revno: 10285.1.4
>    committer: Benjamin Wolsey <address@hidden>
>    branch nick: test
>    timestamp: Tue 2008-11-18 10:46:03 +0100
>    message:
>      Drop another remnant of libxml.
>    modified:
>      libcore/asobj/XML_as.h
>    ------------------------------------------------------------
>    revno: 10285.1.5
>    committer: Benjamin Wolsey <address@hidden>
>    branch nick: test
>    timestamp: Tue 2008-11-18 10:48:27 +0100
>    message:
>      Unused variables.
>    modified:
>      libcore/asobj/XML_as.cpp