[Gnash-commit] gnash ChangeLog testsuite/misc-ming.all/action_...

[Zou Lunkai]

CVSROOT:        /sources/gnash
Module name:    gnash
Changes by:     Zou Lunkai <zoulunkai>  07/09/06 01:55:45

Modified files:
        .              : ChangeLog 
        testsuite/misc-ming.all: action_execution_order_test3.c 

Log message:
        * testsuite/misc-ming.all/action_execution_order_test3.c: Reorganize 
and recomment the source file, please make sure you know the tags order of 
produced swf file  after your update.
        
        Don't make random changes of these actions order related testfiles, 
unless you are sure you could control Ming in the source level. The order of 
placement tags of Ming is very confusing. A better way is always dumping the 
produced swf file and make a double check when you wirte actions order related 
testfiles.

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/gnash/ChangeLog?cvsroot=gnash&r1=1.4234&r2=1.4235
http://cvs.savannah.gnu.org/viewcvs/gnash/testsuite/misc-ming.all/action_execution_order_test3.c?cvsroot=gnash&r1=1.3&r2=1.4

Patches:
Index: ChangeLog
===================================================================
RCS file: /sources/gnash/gnash/ChangeLog,v
retrieving revision 1.4234
retrieving revision 1.4235
diff -u -b -r1.4234 -r1.4235
--- ChangeLog   5 Sep 2007 19:27:49 -0000       1.4234
+++ ChangeLog   6 Sep 2007 01:55:44 -0000       1.4235
@@ -1,3 +1,9 @@
+2007-09-06 Zou Lunkai <address@hidden>
+
+       * testsuite/misc-ming.all/action_execution_order_test3.c: Reorganize 
and recomment
+         the source file, please make sure you know the tags order of produced 
swf file 
+         after your update.
+         
 2007-09-05 Sandro Santilli <address@hidden>
 
        * server/dlist.cpp (removeUnloaded): also remove from _timelineChars.

Index: testsuite/misc-ming.all/action_execution_order_test3.c
===================================================================
RCS file: 
/sources/gnash/gnash/testsuite/misc-ming.all/action_execution_order_test3.c,v
retrieving revision 1.3
retrieving revision 1.4
diff -u -b -r1.3 -r1.4
--- testsuite/misc-ming.all/action_execution_order_test3.c      5 Sep 2007 
19:06:21 -0000       1.3
+++ testsuite/misc-ming.all/action_execution_order_test3.c      6 Sep 2007 
01:55:45 -0000       1.4
@@ -63,28 +63,27 @@
   SWFMovie_nextFrame(mo); /* 1st frame */
 
   add_actions(mo, "_root.x1 += \"as_in_DoAction1+\"; ");
+  add_actions(mo, "_root.x1 += \"as_in_DoAction2+\"; ");
   
   mc_red1 = newSWFMovieClip();
   sh_red = make_fill_square (0, 300, 60, 60, 255, 0, 0, 255, 0, 0);
   SWFMovieClip_add(mc_red1, (SWFBlock)sh_red);  
   SWFMovieClip_nextFrame(mc_red1); /* mc_red1, 1st frame */
 
-  add_actions(mo, "_root.x1 += \"as_in_DoAction2+\"; ");
-   
   /* add mc_red1 to _root and name it as "mc_red1" */
   SWFDisplayItem it_red1, it_red2, it_red3;
-  it_red1 = SWFMovie_add(mo, (SWFBlock)mc_red1);  
+  it_red1 = SWFMovie_add(mo, (SWFBlock)mc_red1);  // PlaceObject2
   SWFDisplayItem_setDepth(it_red1, 10); 
   SWFDisplayItem_addAction(it_red1,
-    compileSWFActionCode("_root.x1 += \"onLoad+\";"),
+    compileSWFActionCode("_root.x1 += \"onLoadRed1+\";"),
     SWFACTION_ONLOAD);
   SWFDisplayItem_addAction(it_red1,
-    compileSWFActionCode("_root.x1 += \"onUnload+\";"),
+    compileSWFActionCode("_root.x1 += \"onUnloadRed1+\";"),
     SWFACTION_UNLOAD);
   SWFDisplayItem_setName(it_red1, "mc_red1"); 
 
   /* add mc_red1 to _root and name it as "mc_red2" */
-  it_red2 = SWFMovie_add(mo, (SWFBlock)mc_red1);  
+  it_red2 = SWFMovie_add(mo, (SWFBlock)mc_red1);  // PlaceObject2
   SWFDisplayItem_setDepth(it_red2, 11); 
   SWFDisplayItem_addAction(it_red2,
     compileSWFActionCode("_root.x1 += \"onLoadRed2+\";"),
@@ -96,13 +95,14 @@
 
   SWFMovie_nextFrame(mo); /* 2nd frame */
 
-  SWFDisplayItem_remove(it_red2);
   add_actions(mo, "_root.x1 += \"as_in_DoAction3+\"; ");
-  SWFDisplayItem_remove(it_red1);
+  // Don't try to remove mc_red2 before mc_red1, you *can not* control
+  // this in the source level! Or at least it is more difficult than you 
imagine.
+  SWFDisplayItem_remove(it_red1); // RemoveObject2
+  SWFDisplayItem_remove(it_red2); // RemoveObject2
   SWFMovie_nextFrame(mo); /* 3th frame */
   
-  // could this be due to Ming reordering tags ?
-  check_equals(mo, "_root.x1", 
"'as_in_DoAction1+as_in_DoAction2+onLoad+onLoadRed2+as_in_DoAction3+onUnload+onUnloadRed2+'");
+  check_equals(mo, "_root.x1", 
"'as_in_DoAction1+as_in_DoAction2+onLoadRed1+onLoadRed2+as_in_DoAction3+onUnloadRed1+onUnloadRed2+'");
   add_actions(mo, " _root.totals(); stop(); ");
   SWFMovie_nextFrame(mo); /* 4th frame */
 
@@ -112,6 +112,3 @@
 
   return 0;
 }
-
-
-