gnash-commit
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Gnash-commit] gnash ChangeLog server/xmlattrs.h server/xmlnod...


From: Sandro Santilli
Subject: Re: [Gnash-commit] gnash ChangeLog server/xmlattrs.h server/xmlnod...
Date: Wed, 22 Nov 2006 16:53:15 +0100

On Wed, Nov 22, 2006 at 08:47:10AM -0700, Rob Savoye wrote:
> Sandro Santilli wrote:
> 
> >               use delete [] when allocating with new [].
> >               (why aren't we using std::string, btw ?)
> 
>   Because the XML code is ancient, and inherited from GameSWF. Since it
> became Gnash, nobody has really worked on it much. As far as I can tell,
> all the XML code is broken anyway due to bit rot.

NetConnection seems also broken, for likely the same reason (htons, etc).
Valgrind reports use of uninitialized memory too, it's using the gethostbyname
which is not threadsafe, and is also making wrong assumptions about internals...

--strk;




reply via email to

[Prev in Thread] Current Thread [Next in Thread]