[Gnash-commit] gnash ChangeLog server/xmlattrs.h server/xmlnod...

[Sandro Santilli]

CVSROOT:        /sources/gnash
Module name:    gnash
Changes by:     Sandro Santilli <strk>  06/11/22 15:19:51

Modified files:
        .              : ChangeLog 
        server         : xmlattrs.h xmlnode.cpp xmlnode.h 

Log message:
                * server/: xmlattrs.h, xmlnode.cpp, xmlnode.h:
                  use delete [] when allocating with new [].
                  (why aren't we using std::string, btw ?)

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/gnash/ChangeLog?cvsroot=gnash&r1=1.1710&r2=1.1711
http://cvs.savannah.gnu.org/viewcvs/gnash/server/xmlattrs.h?cvsroot=gnash&r1=1.9&r2=1.10
http://cvs.savannah.gnu.org/viewcvs/gnash/server/xmlnode.cpp?cvsroot=gnash&r1=1.21&r2=1.22
http://cvs.savannah.gnu.org/viewcvs/gnash/server/xmlnode.h?cvsroot=gnash&r1=1.10&r2=1.11

Patches:
Index: ChangeLog
===================================================================
RCS file: /sources/gnash/gnash/ChangeLog,v
retrieving revision 1.1710
retrieving revision 1.1711
diff -u -b -r1.1710 -r1.1711
--- ChangeLog   22 Nov 2006 14:58:24 -0000      1.1710
+++ ChangeLog   22 Nov 2006 15:19:51 -0000      1.1711
@@ -1,5 +1,11 @@
 2006-11-22 Sandro Santilli <address@hidden>
 
+       * server/: xmlattrs.h, xmlnode.cpp, xmlnode.h:
+         use delete [] when allocating with new [].
+         (why aren't we using std::string, btw ?)
+
+2006-11-22 Sandro Santilli <address@hidden>
+
        * testsuite/actionscript.all/Function.as: tweaked
          tests to take into account differences in numerical
          computations between SWF target version.

Index: server/xmlattrs.h
===================================================================
RCS file: /sources/gnash/gnash/server/xmlattrs.h,v
retrieving revision 1.9
retrieving revision 1.10
diff -u -b -r1.9 -r1.10
--- server/xmlattrs.h   20 Nov 2006 22:06:38 -0000      1.9
+++ server/xmlattrs.h   22 Nov 2006 15:19:51 -0000      1.10
@@ -52,6 +52,8 @@
     XMLAttr();
     ~XMLAttr();
   
+    // why don't we use std::strings here ?
+    // code would be much simpler and safer!
     char                *_name;
     char                *_value;
     xmlAttributeType    _type;

Index: server/xmlnode.cpp
===================================================================
RCS file: /sources/gnash/gnash/server/xmlnode.cpp,v
retrieving revision 1.21
retrieving revision 1.22
diff -u -b -r1.21 -r1.22
--- server/xmlnode.cpp  29 Oct 2006 18:34:11 -0000      1.21
+++ server/xmlnode.cpp  22 Nov 2006 15:19:51 -0000      1.22
@@ -18,7 +18,7 @@
 //
 //
 
-/* $Id: xmlnode.cpp,v 1.21 2006/10/29 18:34:11 rsavoye Exp $ */
+/* $Id: xmlnode.cpp,v 1.22 2006/11/22 15:19:51 strk Exp $ */
 
 #ifdef HAVE_CONFIG_H
 #include "config.h"
@@ -72,19 +72,19 @@
   
     for (i=0; i<_children.size(); i++) {
      if (_children[i]->_name) {
-       delete _children[i]->_name;
+       delete [] _children[i]->_name;
      }
      if (_children[i]->_value) {
-       delete _children[i]->_value;
+       delete [] _children[i]->_value;
      }
     }
 
     for (i=0; i<_attributes.size(); i++) {
        if (_attributes[i]->_name) {
-           delete _attributes[i]->_name;
+           delete [] _attributes[i]->_name;
        }
        if (_attributes[i]->_value) {
-           delete _attributes[i]->_value;
+           delete [] _attributes[i]->_value;
        }
     }
 
@@ -92,10 +92,10 @@
     _attributes.clear();
 
     if (_name) {
-        delete _name;
+        delete [] _name;
     }
     if (_value) {
-        delete _value;
+        delete [] _value;
     }
     //  _value.set_undefined();
 }

Index: server/xmlnode.h
===================================================================
RCS file: /sources/gnash/gnash/server/xmlnode.h,v
retrieving revision 1.10
retrieving revision 1.11
diff -u -b -r1.10 -r1.11
--- server/xmlnode.h    29 Oct 2006 18:34:11 -0000      1.10
+++ server/xmlnode.h    22 Nov 2006 15:19:51 -0000      1.11
@@ -110,8 +110,11 @@
     void  change_stack_frame(int frame, gnash::as_object *xml, 
gnash::as_environment *env);
 
 
+    // why don't we use std::strings here ?
+    // code would be much simpler and safer!
     char                *_name;
     char                *_value;
+
     xmlElementType      _type;
     std::vector<as_object *>  _objects;
     std::vector<XMLNode *>    _children;