[Gnash-commit] gnash ChangeLog server/Function.cpp server/Func...

[Sandro Santilli]

CVSROOT:        /sources/gnash
Module name:    gnash
Changes by:     Sandro Santilli <strk>  06/06/21 20:56:38

Modified files:
        .              : ChangeLog 
        server         : Function.cpp Function.h 

Log message:
        * server/Function.cpp, server/Function.h: updated doxygen comments, 
used size_t for action_buffer offsets and length.

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/gnash/ChangeLog?cvsroot=gnash&r1=1.425&r2=1.426
http://cvs.savannah.gnu.org/viewcvs/gnash/server/Function.cpp?cvsroot=gnash&r1=1.16&r2=1.17
http://cvs.savannah.gnu.org/viewcvs/gnash/server/Function.h?cvsroot=gnash&r1=1.9&r2=1.10

Patches:
Index: ChangeLog
===================================================================
RCS file: /sources/gnash/gnash/ChangeLog,v
retrieving revision 1.425
retrieving revision 1.426
diff -u -b -r1.425 -r1.426
--- ChangeLog   21 Jun 2006 14:20:53 -0000      1.425
+++ ChangeLog   21 Jun 2006 20:56:38 -0000      1.426
@@ -1,15 +1,15 @@
-2006-06-21 Vitaly Alexeev <address@hidden>
+2006-06-22 Sandro Santilli <address@hidden>
 
-       * server/action_buffer.h: removed unnecessary operator=
+       * server/Function.cpp, server/Function.h:
+       updated doxygen comments, used size_t for action_buffer
+       offsets and length.
 
 2006-06-21 Vitaly Alexeev <address@hidden>
 
+       * server/action_buffer.h: removed unnecessary operator=
        * server/action.cpp: fixed "static SWFHandlers ash;" problem
        * server/swf/ASHandler.cpp: fixed "static SWFHandlers ash;" problem
        * server/action_buffer.cpp: fixed "static SWFHandlers ash;" problem
-
-2006-06-21 Vitaly Alexeev <address@hidden>
-
        * server/action_buffer.h: added operator=
        * server/gnash.h: ported to win32
        * server/impl.h: removed read() from swf_event

Index: server/Function.cpp
===================================================================
RCS file: /sources/gnash/gnash/server/Function.cpp,v
retrieving revision 1.16
retrieving revision 1.17
diff -u -b -r1.16 -r1.17
--- server/Function.cpp 7 Jun 2006 03:03:21 -0000       1.16
+++ server/Function.cpp 21 Jun 2006 20:56:38 -0000      1.17
@@ -183,7 +183,7 @@
 }
 
 function_as_object::function_as_object(action_buffer* ab, as_environment* env,
-               int start, const std::vector<with_stack_entry>& with_stack)
+               size_t start, const std::vector<with_stack_entry>& with_stack)
                :
                as_object(getFunctionPrototype()), 
                ctor(0),

Index: server/Function.h
===================================================================
RCS file: /sources/gnash/gnash/server/Function.h,v
retrieving revision 1.9
retrieving revision 1.10
diff -u -b -r1.9 -r1.10
--- server/Function.h   29 Apr 2006 00:56:38 -0000      1.9
+++ server/Function.h   21 Jun 2006 20:56:38 -0000      1.10
@@ -59,6 +59,8 @@
        as_c_function_ptr ctor;
 
 public:
+
+       /// Action buffer containing the function definition
        action_buffer*  m_action_buffer;
 
        /// @@ might need some kind of ref count here, but beware cycles
@@ -67,8 +69,18 @@
        /// initial with-stack on function entry.
        std::vector<with_stack_entry>   m_with_stack;
 
-       int     m_start_pc;
-       int     m_length;
+       /// \brief
+       /// Offset within the action_buffer where
+       /// start of the function is found.
+       size_t  m_start_pc;
+
+       /// Length of the function within the action_buffer
+       //
+       /// This is currently expressed in bytes as the
+       /// action_buffer is just a blog of memory corresponding
+       /// to a DoAction block
+       size_t m_length;
+
        struct arg_spec
        {
                int     m_register;
@@ -114,15 +126,23 @@
        ///
        function_as_object(as_object* export_iface);
 
+       /// \brief
+       /// Create an ActionScript function as defined in an
+       /// action_buffer starting at offset 'start'
+       //
        /// NULL environment is allowed -- if so, then
        /// functions will be executed in the caller's
        /// environment, rather than the environment where they
        /// were defined.
+       ///
        function_as_object(action_buffer* ab, as_environment* env,
-                       int start, const std::vector<with_stack_entry>& 
with_stack);
+               size_t start,
+               const std::vector<with_stack_entry>& with_stack);
 
        void    set_is_function2() { m_is_function2 = true; }
+
        void    set_local_register_count(uint8 ct) { assert(m_is_function2); 
m_local_register_count = ct; }
+
        void    set_function2_flags(uint16 flags) { assert(m_is_function2); 
m_function2_flags = flags; }
 
        void    add_arg(int arg_register, const char* name)