[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Gnash-commit] gnash/server action_buffer.h
From: |
strk |
Subject: |
Re: [Gnash-commit] gnash/server action_buffer.h |
Date: |
Wed, 21 Jun 2006 18:11:15 +0200 |
Sorry if I'm bothering, but if the comments above the copy ctor
are correct we'd better assert(0) in the assigment op too.
--strk;
On Wed, Jun 21, 2006 at 02:18:59PM +0000, Vitaly Alexeev wrote:
> CVSROOT: /sources/gnash
> Module name: gnash
> Changes by: Vitaly Alexeev <alexeev> 06/06/21 14:18:58
>
> Modified files:
> server : action_buffer.h
>
> Log message:
> removed unnecessary "void operator=()"
>
> CVSWeb URLs:
> http://cvs.savannah.gnu.org/viewcvs/gnash/server/action_buffer.h?cvsroot=gnash&r1=1.2&r2=1.3
>
> Patches:
> Index: action_buffer.h
> ===================================================================
> RCS file: /sources/gnash/gnash/server/action_buffer.h,v
> retrieving revision 1.2
> retrieving revision 1.3
> diff -u -b -r1.2 -r1.3
> --- action_buffer.h 21 Jun 2006 08:46:03 -0000 1.2
> +++ action_buffer.h 21 Jun 2006 14:18:58 -0000 1.3
> @@ -103,11 +103,6 @@
>
> int get_length() const { return m_buffer.size(); }
>
> - void operator=(const action_buffer& a)
> - {
> - m_buffer.assign(a.m_buffer.begin(), a.m_buffer.end());
> - }
> -
> private:
> // Don't put these as values in std::vector<>! They contain
> // internal pointers and cannot be moved or copied.
>
>
> _______________________________________________
> Gnash-commit mailing list
> address@hidden
> http://lists.gnu.org/mailman/listinfo/gnash-commit
--
/"\ ASCII Ribbon Campaign
\ / Respect for low technology.
X Keep e-mail messages readable by any computer system.
/ \ Keep it ASCII.