[Freeipmi-devel] Extending ipmi-sel OEM information for Supermicro boards

[devlists]

Hi Al,

I hope you are doing fine. After quite some time, I'm now again more 
active in the area of using additional freeipmi-tools with Supermicro 
servers. Especially we want to provide a second Nagios/Icinga plugin 
(check_ipmi_sel) in addition to check_ipmi_sensor.

I have run ipmi-sel (v1.4.5 taken from Debian unstable) on a system 
with Supermicro X9SCM-F.
I have found that some events/sensor names are mentioned with "Sensor 
#255" or "Event Offset = 00h":
address@hidden:~# ipmi-sel --output-event-state -v 
--interpret-oem-data --entity-sensor-names
ID   | Date        | Time     | Name                                    
         | Type              | State    | Event Direction   | Event
1    | PostInit    | PostInit | Sensor #255                             
         | OEM Reserved      | N/A      | Assertion Event   | Event 
Offset = 00h
2    | Sep-23-2014 | 07:50:12 | System Chassis Chassis Intru            
         | Physical Security | Critical | Assertion Event   | General 
Chassis Intrusion
3    | Sep-24-2014 | 12:01:29 | Sensor #255                             
         | Session Audit     | Warning  | Assertion Event   | Invalid 
Username of Password
4    | Sep-30-2014 | 08:15:00 | System Chassis Chassis Intru            
         | Physical Security | Critical | Assertion Event   | General 
Chassis Intrusion
5    | Sep-30-2014 | 08:25:57 | System Chassis Chassis Intru            
         | Physical Security | Critical | Assertion Event   | General 
Chassis Intrusion
6    | Oct-28-2014 | 11:21:49 | System Chassis Chassis Intru            
         | Physical Security | Critical | Assertion Event   | General 
Chassis Intrusion
7    | Nov-04-2014 | 08:55:28 | System Chassis Chassis Intru            
         | Physical Security | Critical | Deassertion Event | General 
Chassis Intrusion
address@hidden:~# ipmi-sel --output-event-state -v 
--interpret-oem-data --entity-sensor-names --debug &> 
ipmi-sel-1-debug.txt
address@hidden:~# ipmi-sel --debug &> ipmi-sel-2-debug.txt
(I have attached the two debug outputs for your reference.)

In the IPMI web interface these entries 1 and 3 are displayed as 
follows:
  For ID 1:
    Time Stamp: 1970/01/01 00:00:36
    Sensor Name: OEM
    Sensor Type: AC Power On
    Description: AC Power On - Asserted
  For ID 3:
    Time Stamp: 2014/09/24 12:01:29
    Sensor Name: (is blank)
    Sensor Type: Session Audit
    Description: Invalid Username or Password

My questions:
1) Can you maybe add this "AC Power On" to freeipmi, so that it is 
displayed instead of "Event Offset = 00h"?
2) If noticed a typo ("of" instead of "or") in 
/libfreeipmi/spec/ipmi-sensor-and-event-code-tables-spec.c on line 1080 
(of the 1.4.6 source code) it should be "Username or Password" instead 
of "Username of Password":
   const char * const ipmi_sensor_type_session_audit_short[] =
     {
       "Session Activated",
       "Session Deactivated",
       "Invalid Username of Password",
       "Invalid Password Disable",
       NULL
     };
   It's only cosmetic, but could you fix this?
3) I've noticed that ipmitool 1.8.14 got support to display Supermicro 
memory ECC information in the SEL correctly ("ID: 85 - Supermicro memory 
ECC error display"):
     http://sourceforge.net/projects/ipmitool/files/ipmitool/1.8.14/
     
http://sourceforge.net/p/ipmitool/source/ci/2d7fe326874a9f151173619b7c714d12cb4d2880/
     
http://sourceforge.net/p/ipmitool/source/ci/3a852a884922494cc8daf56dbd6056bfd34f10c8/
   I have no faulty memory, so I cannot test it whether freeipmi has 
support for this, too.
   In case that there is currently no support for this in freeipmi, 
could you consider adding support for it in the future?

Thank you once again for the great freeipmi-tools that you are 
providing and you ongoing development,
best regards from Austria,
Werner

ipmi-sel-1-debug.txt.gz
Description: application/gzip

ipmi-sel-2-debug.txt.gz
Description: application/gzip