Re: [Freeipmi-devel] Patch for SHA256 Support

[Albert Chu]

Hi Holger,

Thanks for the patch.  This was on my todo, but w/o a motherboard to
test on, I just let it linger.  I think you forgot to add the
appropriate permutation of cipher suite/SHA256 into
libfreeipmi/src/debug/ and the manpages in common/man/, but no worries,
I can add that myself.

Only one question, are cipher suites 15-17 defined in the upcoming DCMI
1.1?  ASAIK it hasn't been released publicly.  I have a tiny concern
about committing something that is not yet finalized.  Or is DCMI 1.1
finalized and going to be released publicly soon??

Al

On Thu, 2010-07-29 at 06:07 -0700, Liebig, Holger wrote:
> Hi all,
> please find attached the required modification for SHA256 and Cipher
> Suite 17 support in freeipmi. SHA256 has been added in IPMI 2.0 Errata
> 4 and is also one of the recommended Cipher Suites of the upcoming
> DCMI 1.1 Specification (where the Cipher Suite number is taken from).
> The modifications itself are straight forward, I just had to find all
> the places.
> 
> Comments or feedback is more than welcome, especially if it works with
> other vendor implementations.
> 
> Thanks,
> Holger
> 
> 
> 
> 
> 
-- 
Albert Chu
address@hidden
Computer Scientist
High Performance Systems Division
Lawrence Livermore National Laboratory