[Freeipmi-devel] [PATCH 4/9] Don't start running service

[Jan Safranek]

LSB specifies that 'start' operation on already running service should
return exit code 0 and do nothing.

I am not sure how the code path with /etc/rc.status instead of
/etc/init.d/functions works, does rc_status -v set RETVAL and returns the same
exit code?

Signed-off-by: Jan Safranek <address@hidden>
---

 bmc-watchdog/freeipmi-bmc-watchdog.init |    2 ++
 ipmidetect/freeipmi-ipmidetectd.init    |    2 ++
 2 files changed, 4 insertions(+), 0 deletions(-)

diff --git a/bmc-watchdog/freeipmi-bmc-watchdog.init 
b/bmc-watchdog/freeipmi-bmc-watchdog.init
index 0d07a11..d161931 100755
--- a/bmc-watchdog/freeipmi-bmc-watchdog.init
+++ b/bmc-watchdog/freeipmi-bmc-watchdog.init
@@ -51,6 +51,7 @@ if [ -f /etc/rc.d/init.d/functions ] ; then
     Xstatus() {
         status bmc-watchdog
        RETVAL=$?
+        return $RETVAL
     }
     Xcondrestart() {
         if test -e $LOCKFILE; then
@@ -99,6 +100,7 @@ RETVAL=0
 case "$1" in
    start)
       echo -n "Starting bmc-watchdog: "
+      Xstatus >/dev/null 2>&1 && exit 0
       Xstart
       ;;
 
diff --git a/ipmidetect/freeipmi-ipmidetectd.init 
b/ipmidetect/freeipmi-ipmidetectd.init
index cb2325d..101fe58 100644
--- a/ipmidetect/freeipmi-ipmidetectd.init
+++ b/ipmidetect/freeipmi-ipmidetectd.init
@@ -37,6 +37,7 @@ if [ -f /etc/rc.d/init.d/functions ] ; then
     Xstatus() {
         status ipmidetectd
        RETVAL=$?
+        return $RETVAL
     }
     Xcondrestart() {
         if test -e /var/lock/subsys/freeipmi-ipmidetectd; then
@@ -85,6 +86,7 @@ RETVAL=0
 case "$1" in
    start)
        echo -n "Starting ipmidetectd: "
+        Xstatus >/dev/null 2>&1 && exit 0
         Xstart
         ;;
   stop)