[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Findutils-patches] ./configure-time setting of default arg size
From: |
Eric Blake |
Subject: |
Re: [Findutils-patches] ./configure-time setting of default arg size |
Date: |
Mon, 30 Jul 2007 06:48:50 -0600 |
User-agent: |
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.5) Gecko/20070716 Thunderbird/2.0.0.5 Mnenhy/0.7.5.666 |
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
According to James Youngman on 7/26/2007 12:51 PM:
> On 7/26/07, Eric Blake <address@hidden> wrote:
>> +AC_ARG_VAR([DEFAULT_ARG_SIZE], [Default size of arguments to child
>> processes
>> +of find and xargs, 128k if unspecified])
>> +if test -n "$DEFAULT_ARG_SIZE"; then
>> + AC_DEFINE_UNQUOTED([ARG_SIZE], [$DEFAULT_ARG_SIZE],
>> + [If defined, the default maximum argument size used in child
>> processes])
>> +fi
>
> Seems OK, but please use something a bit more specific than just
> ARG_SIZE as the macro. I think the README file probably also needs
> to include a description of the new configure option and the NEWS file
> should probably tell the reader to refer to that.
OK, I'll rework the patch along those lines. Would the macro name
DEFAULT_ARG_SIZE be better than ARG_SIZE here? Based on my additional
comments to #20594, I think it is still worth tying this patch to 20594; I
just have to be careful to not call it a bug fix (because it is not a
findutils bug that cygwin's current choice of _SC_ARG_MAX values doesn't
work when invoking non-cygwin apps), but instead call it an enhancement.
- --
Don't work too hard, make some time for fun as well!
Eric Blake address@hidden
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iD8DBQFGrd4y84KuGfSFAYARAhO2AKCWYSauOn6yI/pOoNPx84EiR9a5fgCgyxGi
Ek+Xb6S0XnMpEUfKBCmwy/Y=
=OS28
-----END PGP SIGNATURE-----