Re: [Findutils-patches] ./configure-time setting of default arg size

[James Youngman]

On 7/26/07, James Youngman <address@hidden> wrote:
> On 7/26/07, Eric Blake <address@hidden> wrote:
> > +AC_ARG_VAR([DEFAULT_ARG_SIZE], [Default size of arguments to child processes
> > +of find and xargs, 128k if unspecified])
> > +if test -n "$DEFAULT_ARG_SIZE"; then
> > +   AC_DEFINE_UNQUOTED([ARG_SIZE], [$DEFAULT_ARG_SIZE],
> > +     [If defined, the default maximum argument size used in child processes])
> > +fi
>
> Seems OK, but please use something a bit more specific than just
> ARG_SIZE as the macro.   I think the README file probably also needs
> to include a description of the new configure option and the NEWS file
> should probably tell the reader to refer to that.

I should clarify.   The change itself seems OK, but I believe that
making this particular change is not the right way to fix bug #20594.
I don't object to the change itself, but imho it doesn't fix the bug.

James.