[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Adding custom providers for thingatpt.el (was: [PATCH] Add support f
From: |
Eli Zaretskii |
Subject: |
Re: Adding custom providers for thingatpt.el (was: [PATCH] Add support for 'thing-at-point' to get URL at point) |
Date: |
Sat, 18 May 2024 11:26:29 +0300 |
> Date: Tue, 30 Apr 2024 11:27:04 -0700
> Cc: eliz@gnu.org, emacs-devel@gnu.org, emacs-orgmode@gnu.org
> From: Jim Porter <jporterbugs@gmail.com>
>
> On 4/30/2024 4:39 AM, Ihor Radchenko wrote:
> > What happens if you have multiple providers for an URL?
> > You add the provider to the end, so it will have the lower priority in
> > this scenario. I guess that you want the opposite - EWW provider to take
> > precedence. Same for other changes.
>
> That's probably reasonable. I was just keeping things the way they were
> historically here, but we might as well fix this now.
>
> > It would make sense to add tests for "first wins" behaviour.
>
> Done.
>
> I've also fixed a bug in EWW and bug-reference-mode where it would
> return nil for (thing-at-point 'url) if point was at the *end* of a URL.
> It's now consistent with how 'thing-at-point' works by default. (If you
> have two consecutive URLs and point is between them - only possible with
> the custom provider function, I think - it'll prefer the second one.)
I think you can install this now.
- Re: Adding custom providers for thingatpt.el (was: [PATCH] Add support for 'thing-at-point' to get URL at point),
Eli Zaretskii <=
- Re: Adding custom providers for thingatpt.el (was: [PATCH] Add support for 'thing-at-point' to get URL at point), Jim Porter, 2024/05/19
- Re: Adding custom providers for thingatpt.el (was: [PATCH] Add support for 'thing-at-point' to get URL at point), Jim Porter, 2024/05/19
- Re: Adding custom providers for thingatpt.el (was: [PATCH] Add support for 'thing-at-point' to get URL at point), Ihor Radchenko, 2024/05/20
- Re: Adding custom providers for thingatpt.el (was: [PATCH] Add support for 'thing-at-point' to get URL at point), Jim Porter, 2024/05/20
- Re: Adding custom providers for thingatpt.el (was: [PATCH] Add support for 'thing-at-point' to get URL at point), Ihor Radchenko, 2024/05/25
- Re: Adding custom providers for thingatpt.el (was: [PATCH] Add support for 'thing-at-point' to get URL at point), Jim Porter, 2024/05/26
- Re: Adding custom providers for thingatpt.el (was: [PATCH] Add support for 'thing-at-point' to get URL at point), Ihor Radchenko, 2024/05/26
- Re: Adding custom providers for thingatpt.el (was: [PATCH] Add support for 'thing-at-point' to get URL at point), Jim Porter, 2024/05/26
- Re: Adding custom providers for thingatpt.el, Max Nikulin, 2024/05/21
- Re: Adding custom providers for thingatpt.el, Jim Porter, 2024/05/21