emacs-orgmode
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: PATCH: include controlling language= in my previous patch


From: Pedro Andres Aranda Gutierrez
Subject: Re: PATCH: include controlling language= in my previous patch
Date: Tue, 13 Dec 2022 12:08:33 +0100

Hi,

thanks for the patience. I hope to have implemented all suggestions by now.

BR,/PA

On Tue, 13 Dec 2022 at 10:24, Ihor Radchenko <yantar92@posteo.net> wrote:
Pedro Andres Aranda Gutierrez <paaguti@gmail.com> writes:

> I've (finally) followed the procedure and broken up the patch in two. One
> for the labels= ,caption=  and one for the language= control.

Thanks!
You also need to provide etc/ORG-NEWS entry since we are adding a new
feature here.

> FYI, I have already cleared the FSF paperwork for an emacs patch.

Bastien, could you kindly confirm?

> Subject: [PATCH 2/2] Allow to suppress language= in SRC blocks

Please also provide changelog entries. See
https://orgmode.org/worg/org-contribute.html#commit-messages

> +(defcustom org-latex-listings-src-omit-language nil
> +  "Set this option to t to omit the
> +\"language=\"
> +in the parameters to \\begin{lstlisting} when exporting a src block"

Please describe in the docstring when this kind of setting is needed.

> +  :group 'org-export-latex
> +  :version "30.0"

:version is not necessary. See 15.1 Common Item Keywords section of
Elisp manual:

    ‘:version VERSION’
         This keyword specifies that the item was first introduced in Emacs
         version VERSION, or that its default value was changed in that
         version.  The value VERSION must be a string.

    ‘:package-version '(PACKAGE . VERSION)’
         This keyword specifies that the item was first introduced in
         PACKAGE version VERSION, or that its meaning or default value was
         changed in that version.  This keyword takes priority over
                                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
         ‘:version’.
         ^^^^^^^^^^^

--
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>


--
Fragen sind nicht da um beantwortet zu werden,
Fragen sind da um gestellt zu werden
Georg Kreisler

Headaches with a Juju log:
unit-basic-16: 09:17:36 WARNING juju.worker.uniter.operation we should run a leader-deposed hook here, but we can't yet

Attachment: 0001-Don-t-emit-empty-labels-and-captions-in-SRC-blocks.patch
Description: Text Data

Attachment: 0004-Add-entries-to-ORG-NEWS-for-changes-and-org-latex-li.patch
Description: Text Data

Attachment: 0002-Allow-to-suppress-language-in-SRC-blocks.patch
Description: Text Data

Attachment: 0003-Refine-DOCSTRING-for-org-latex-listings-src-omit-lan.patch
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]